Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: modules/adblockplus/templates/telemetry/endpoint.conf.erb
Issue
29329669
:
Issue 3261 - Introduce module adblockplus::telemetry (Closed)
Patch Set: Issue 3261 - Fix adblockplus::telemetry documentation typos
Created Nov. 11, 2015, 6:15 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Issue 3261 - Fix adblockplus::telemetry documentation typos
Patch Set 3: Issue 3261 - Rename /submit/{filter-hit-statistics => adblockplus}
Right:
Patch Set 1: None
Patch Set 2: Issue 3261 - Fix adblockplus::telemetry documentation typos
Patch Set 3: Issue 3261 - Rename /submit/{filter-hit-statistics => adblockplus}
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
hiera/roles/telemetryserver.yaml
modules/adblockplus/manifests/telemetry.pp
modules/adblockplus/manifests/telemetry/endpoint.pp
modules/adblockplus/templates/telemetry/endpoint.conf.erb
modules/adblockplus/templates/telemetry/logrotate.erb
modules/private-stub/hiera/hosts.yaml
View unified diff
|
Download patch
« no previous file with comments
|
« modules/adblockplus/manifests/telemetry/endpoint.pp
('k') |
modules/adblockplus/templates/telemetry/logrotate.erb »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
# Puppet: Adblockplus::Telemetry::Endpoint['<%= @title %>']
2
location = <%= @location %> {
3
access_log <%= @logfile %> data;
4
echo_read_request_body;
5
}
6
OLD
NEW
« no previous file with comments
|
« modules/adblockplus/manifests/telemetry/endpoint.pp
('k') |
modules/adblockplus/templates/telemetry/logrotate.erb »
('j') |
no next file with comments »
Edit Message
Issue 29329669: Issue 3261 - Introduce module adblockplus::telemetry (Closed)
Created Nov. 3, 2015, 4:46 a.m. by mathias
Modified Nov. 16, 2015, 10:32 a.m.
Reviewers: Fred, Felix Dahlke
Base URL:
Comments: 4
This is Rietveld