Issue 3129/3144 - Don`t let the findbar intercept keyboard events when editing filters

chrome/content/ui/filters-filterview.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 644 matching lines @@
         this.atoms[atom + "-false"] = atomService.getAtom(atom + "-false");
       }
 
       let columns = this.boxObject.columns;
       for (let i = 0; i < columns.length; i++)
         if (columns[i].element.hasAttribute("sortDirection"))
           this.sortBy(columns[i].id, columns[i].element.getAttribute("sortDirection"));
 
       this.refresh(true);
     }
+
+    // Stop propagation of keypress events so that these aren't intercepted by
+    // the findbar.
+    this.treeElement.inputField.addEventListener("keypress", event => {
+      event.stopPropagation()

[Thomas Greiner, 2015/11/09 14:43:41]

Detail: Missing semicolon.

[Wladimir Palant, 2015/11/09 15:03:49]

Fixed in the patch I pushed.

+    }, false);
   },
 
   selection: null,
 
   get rowCount() this.data.length,
 
   getCellText: function(row, col)
   {
     if (row < 0 || row >= this.data.length)
       return null;
@@ skipping 153 matching lines @@
   getProgressMode: () => null,
   getImageSrc: () => null,
   isSeparator: () => false,
   performAction: () => {},
   performActionOnRow: () => {},
   performActionOnCell: () => {},
   getCellValue: () => null,
   setCellValue: () => {},
   selectionChanged: () => {}
 };