metadata.common - Issue 29330321: Issue 3334 - Fix warnings spotted during testing before release

Delta Between Two Patch Sets: metadata.common

Issue 29330321: Issue 3334 - Fix warnings spotted during testing before release (Closed)

Left Patch Set: Remove changes to webrequest.js Created Nov. 17, 2015, 7:04 p.m.

Right Patch Set: Remove redundant mapping for the large icon Created Nov. 17, 2015, 9:03 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [general]	1 [general]

2 version = 1.9.3	2 version = 1.9.3

3 backgroundScripts = ext/common.js	3 backgroundScripts = ext/common.js

4 ext/background.js	4 ext/background.js

5 lib/compat.js	5 lib/compat.js

6 lib/info.js	6 lib/info.js

7 lib/adblockplus.js	7 lib/adblockplus.js

8 lib/punycode.js	8 lib/punycode.js

9 lib/publicSuffixList.js	9 lib/publicSuffixList.js

10 lib/sha1.js	10 lib/sha1.js

(...skipping 27 matching lines...) Expand all Loading...
38 document_end = include.postload.js	38 document_end = include.postload.js

39	39

40 [mapping]	40 [mapping]

41 ext/content.js = chrome/ext/content.js	41 ext/content.js = chrome/ext/content.js

42 ext/popup.js = chrome/ext/popup.js	42 ext/popup.js = chrome/ext/popup.js

43 subscriptions.xml = adblockplus/chrome/content/ui/subscriptions.xml	43 subscriptions.xml = adblockplus/chrome/content/ui/subscriptions.xml

44 firstRun.html = adblockplusui/firstRun.html	44 firstRun.html = adblockplusui/firstRun.html

45 firstRun.js = adblockplusui/firstRun.js	45 firstRun.js = adblockplusui/firstRun.js

46 i18n.js = adblockplusui/i18n.js	46 i18n.js = adblockplusui/i18n.js

47 messageResponder.js = adblockplusui/messageResponder.js	47 messageResponder.js = adblockplusui/messageResponder.js

48 skin/abp-128.png = adblockplusui/skin/abp-128.png
Sebastian Noack 2015/11/17 20:39:43 We have following code in firstRun.js specifically We have following code in firstRun.js specifically to avoid bundling this image twice. logo.src = "skin/abp-128.png"; var errorCallback = function() { logo.removeEventListener("error", errorCallback, false); // We are probably in Chrome/Opera/Safari, the image has a different path. logo.src = "icons/detailed/abp-128.png"; }; logo.addEventListener("error", errorCallback, false); Apparently, Chrome is still showing an error in the console, for failed requests regardless whether the error has been handled. But that doesn't justify bundling resources redundantly. kzar 2015/11/17 21:04:15 Whoops OK, that makes sense. Done. Show quoted text On 2015/11/17 20:39:43, Sebastian Noack wrote: > We have following code in firstRun.js specifically to avoid bundling this image > twice. > > logo.src = "skin/abp-128.png"; > var errorCallback = function() > { > logo.removeEventListener("error", errorCallback, false); > // We are probably in Chrome/Opera/Safari, the image has a different path. > logo.src = "icons/detailed/abp-128.png"; > }; > logo.addEventListener("error", errorCallback, false); > > Apparently, Chrome is still showing an error in the console, for failed requests > regardless whether the error has been handled. But that doesn't justify bundling > resources redundantly. Whoops OK, that makes sense. Done.
49 icons/detailed/abp-128.png = adblockplusui/skin/abp-128.png	48 icons/detailed/abp-128.png = adblockplusui/skin/abp-128.png

50 skin/firstRun.css = adblockplusui/skin/firstRun.css	49 skin/firstRun.css = adblockplusui/skin/firstRun.css

51 skin/ajax-loader.gif = adblockplusui/skin/ajax-loader.gif	50 skin/ajax-loader.gif = adblockplusui/skin/ajax-loader.gif

52 skin/background.png = adblockplusui/skin/background.png	51 skin/background.png = adblockplusui/skin/background.png

53 skin/background-main.png = adblockplusui/skin/background-main.png	52 skin/background-main.png = adblockplusui/skin/background-main.png

54 skin/background-share.png = adblockplusui/skin/background-share.png	53 skin/background-share.png = adblockplusui/skin/background-share.png

55 skin/donate.png = adblockplusui/skin/donate.png	54 skin/donate.png = adblockplusui/skin/donate.png

56 skin/abb-logo.png = adblockplusui/skin/abb-logo.png	55 skin/abb-logo.png = adblockplusui/skin/abb-logo.png

57 skin/features/malware.png = adblockplusui/skin/features/malware.png	56 skin/features/malware.png = adblockplusui/skin/features/malware.png

58 skin/features/social.png = adblockplusui/skin/features/social.png	57 skin/features/social.png = adblockplusui/skin/features/social.png

(...skipping 67 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
126 addSubscription.label	125 addSubscription.label

127 addSubscriptionAdd.label	126 addSubscriptionAdd.label

128 addSubscriptionOther.label	127 addSubscriptionOther.label

129 acceptableAds2.label	128 acceptableAds2.label

130 viewList.label	129 viewList.label

131 readMore.label	130 readMore.label

132 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label	131 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label

133 title.label	132 title.label

134 adblockplus/chrome/locale/*/meta.properties = =name	133 adblockplus/chrome/locale/*/meta.properties = =name

135 adblockplusui/locale//firstRun.json = =	134 adblockplusui/locale//firstRun.json = =

LEFT	RIGHT