README.md - Issue 29331477: Issue 3340 - Add link to issue tracker in the README.md

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: README.md

Issue 29331477: Issue 3340 - Add link to issue tracker in the README.md

Patch Set: Created Nov. 29, 2015, 1:08 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Adblock Plus for Firefox	1 Adblock Plus for Firefox

2 ========================	2 ========================

3	3

	4 Issues

	5 -------

	6

	7 - [Issue Tracker](https://issues.adblockplus.org/)
	Wladimir Palant 2015/12/01 14:14:54 I'm not sure whether this makes much sense - exter I'm not sure whether this makes much sense - external contributors will usually see the GitHub clone of the repository, and there we don't need to document how to create issues. At the very least, this section should be at the bottom of the document - it's not as important and building and testing requirements. Nit: You have one dash too many below the heading (same with the Building section, not sure why). Erik 2015/12/01 18:06:21 I'm not sure that I understand this. When I went Show quoted text On 2015/12/01 14:14:54, Wladimir Palant wrote: > external contributors will usually > see the GitHub clone of the repository, and there we don't need to document how > to create issues. I'm not sure that I understand this. When I went to the github repo first, and didn't understand where the issue tracker was, so I had to google it. Show quoted text > At the very least, this section should be at the bottom of the > document - it's not as important and building and testing requirements. ok I can do this. Show quoted text > Nit: You have one dash too many below the heading (same with the Building > section, not sure why). Ah ok I'll fix this! I was copying the format below :/ Wladimir Palant 2015/12/01 19:18:59 I see. That's not the typical use case however. No Show quoted text On 2015/12/01 18:06:21, Erik wrote: > I'm not sure that I understand this. When I went to the github repo first, and > didn't understand where the issue tracker was, so I had to google it. I see. That's not the typical use case however. Normally, people want to report issues - you can do this on GitHub as usually. If one wants to see existing issues, most of these aren't on GitHub of course. So the documentation has to mention both. Erik 2016/10/25 18:50:41 This isn't possible at the moment, https://github. Show quoted text On 2015/12/01 19:18:59, Wladimir Palant wrote: > On 2015/12/01 18:06:21, Erik wrote: > > I'm not sure that I understand this. When I went to the github repo first, > and > > didn't understand where the issue tracker was, so I had to google it. > > I see. That's not the typical use case however. Normally, people want to report > issues - you can do this on GitHub as usually. This isn't possible at the moment, https://github.com/adblockplus/adblockplus does not have issues enabled, so one can only submit pull requests and not simply report a issue.
	8

4 Building	9 Building

5 ---------	10 ---------

6	11

7 ### Requirements	12 ### Requirements

8	13

9 - [Python 2.7](https://www.python.org)	14 - [Python 2.7](https://www.python.org)

10 - [The Jinja2 module](http://jinja.pocoo.org/docs)	15 - [The Jinja2 module](http://jinja.pocoo.org/docs)

11	16

12 ### Building the extension	17 ### Building the extension

13	18

(...skipping 19 matching lines...) Expand all Loading...
33 Running the unit tests	38 Running the unit tests

34 ----------------------	39 ----------------------

35	40

36 To verify your changes you can use the existing	41 To verify your changes you can use the existing

37 [unit test suite](https://hg.adblockplus.org/adblockplustests). The unit tests	42 [unit test suite](https://hg.adblockplus.org/adblockplustests). The unit tests

38 are a separate extension that is installed in addition to Adblock Plus. You can	43 are a separate extension that is installed in addition to Adblock Plus. You can

39 either install the	44 either install the

40 [existing unit test builds](https://adblockplus.org/devbuilds/adblockplustests)	45 [existing unit test builds](https://adblockplus.org/devbuilds/adblockplustests)

41 or clone the repository and create your own build. After installing the unit	46 or clone the repository and create your own build. After installing the unit

42 tests go to extension's options and run the unit tests from there.	47 tests go to extension's options and run the unit tests from there.

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »