Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/FilterEngine.h

Issue 29331737: Issue 3363 - Implement IsDocumentWhitelisted and IsElemhideWhitelisted (Closed)
Patch Set: Even more issues Created Dec. 2, 2015, 5:38 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/FilterEngine.cpp » ('j') | src/FilterEngine.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/AdblockPlus/FilterEngine.h
diff --git a/include/AdblockPlus/FilterEngine.h b/include/AdblockPlus/FilterEngine.h
index 40484cc26cb9512a15688d28c354dc67d10cf037..d33751ac99a3d25bf5aee04bd119b1734869a4ae 100644
--- a/include/AdblockPlus/FilterEngine.h
+++ b/include/AdblockPlus/FilterEngine.h
@@ -299,6 +299,34 @@ namespace AdblockPlus
const std::vector<std::string>& documentUrls) const;
/**
+ * Checks whether the document at the supplied URL is whitelisted.
+ * @param url URL of the document
Felix Dahlke 2015/12/02 18:02:01 Nit: Seems we usually end with a period.
René Jeschke 2015/12/02 18:09:41 Done.
+ * @param documentUrls Chain of document URLs requesting the document,
+ * starting with the current documents's parent frame, ending with
Felix Dahlke 2015/12/02 18:02:02 Typo: s/documents's/document's/
René Jeschke 2015/12/02 18:09:41 Done.
+ * the top-level frame.
+ * If the application is not capable of identifying the frame
+ * structure, e.g. because it is a proxy, it can be approximated
+ * using `ReferrerMapping`.
+ * @return `true` if the URL is whitelisted.
+ */
+ bool IsDocumentWhitelisted(const std::string& url,
+ const std::vector<std::string>& documentUrls) const;
+
+ /**
+ * Checks whether element hiding is disabled at the supplied URL.
+ * @param url URL to match.
Felix Dahlke 2015/12/02 18:01:58 Maybe it's not entirely correct, but I think it'd
René Jeschke 2015/12/02 18:09:41 Done.
+ * @param documentUrls Chain of documents requesting the resource, starting
Felix Dahlke 2015/12/02 18:02:01 Same as above, we're not really talking about a "r
René Jeschke 2015/12/02 18:09:42 Done.
+ * with the current resource's parent frame, ending with the
+ * top-level frame.
+ * If the application is not capable of identifying the frame
+ * structure, e.g. because it is a proxy, it can be approximated
+ * using `ReferrerMapping`.
+ * @return `true` if element hiding is whitelisted for the supplied URL.
+ */
+ bool IsElemhideWhitelisted(const std::string& url,
+ const std::vector<std::string>& documentUrls) const;
+
+ /**
* Retrieves CSS selectors for all element hiding filters active on the
* supplied domain.
* @param domain Domain to retrieve CSS selectors for.
@@ -409,6 +437,11 @@ namespace AdblockPlus
void FilterChanged(FilterChangeCallback callback, JsValueList& params);
void ShowNotification(const ShowNotificationCallback& callback,
const JsValueList& params);
+ FilterPtr GetWhitelistingFilter(const std::string& url,
+ ContentType contentType, const std::string& documentUrl) const;
+ FilterPtr GetWhitelistingFilter(const std::string& url,
+ ContentType contentType,
+ const std::vector<std::string>& documentUrls) const;
};
}
« no previous file with comments | « no previous file | src/FilterEngine.cpp » ('j') | src/FilterEngine.cpp » ('J')

Powered by Google App Engine
This is Rietveld