Issue 2359 - Fixed styles of list items in options page

skin/options.css

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 128 matching lines @@
 }
 
 .hbox
 {
   display: flex;
   flex-direction: row;
 }
 
 .hbox > div
 {
-  flex: 1;
+  width: 400px;
 }
 
 .tabs li
 {
   cursor: pointer;
   display: flex;
 }
 
 .tabs li a
 {
@@ skipping 179 matching lines @@
   -moz-padding-start: 16px;
   border-radius: 3px;
 }
 
 .table.list li .display
 {
   flex: 1;
   line-height: 16px;
   overflow: hidden;
   text-overflow: ellipsis;
   white-space: nowrap;

[saroyanm, 2016/01/25 16:32:37]

What about setup max-width as well, because currently the long texts are making
the list items to shrink. 
Maybe 300px ?

[Thomas Greiner, 2016/01/25 18:41:24]

You're right. That behavior must've been introduced by one of the other changes
in this review because it worked as expected when I implemented it.

The style guide defines a "400px" width for each of the quadrants so I went with
that. Note that we don't need to set `flex: 1` since the width doesn't change
anyway.

 }
 
 .table.list li:nth-child(odd),
 .table.cols li:nth-child(even),
 .table li.empty-placeholder
 {
   background-color: #F5F5F5;
 }
 
 .table label
@@ skipping 178 matching lines @@
   vertical-align: top;
 }
 
 /*
   General tab content
 */
 
 #blocking-languages,
 #acceptable-ads
 {
-  -moz-padding-end: 40px;
-  -webkit-padding-end: 40px;
+  -moz-margin-end: 40px;
+  -webkit-margin-end: 40px;
 }
 
 #custom-wrapper
 {
   height: 290px;
   overflow: auto;
 }
 
 #custom-wrapper .table
 {
@@ skipping 357 matching lines @@
   -webkit-margin-end: 6px;
 }
 
 /*
   Dialog
 */
 
 #dialog-background
 {
   display: none;
-  background-color: white;
   position: fixed;
-  opacity: 0.7;
   top: 0px;
   right: 0px;
   bottom: 0px;
   left: 0px;
   z-index: 2;
+  background-color: white;
+  opacity: 0.7;
 }
 
 body[data-dialog] #dialog-background
 {
   display: block;
 }
 
 #dialog
 {
-  background-color: #FFFFFF;
-  border: 2px solid #4D9D4B;
-  border-radius: 3px;
-  margin: auto;
   position: fixed;

[saroyanm, 2016/01/25 16:32:37]

Note: I think whenever we fixing a block we can also make it consistent with
coding-standards we have. 
Anyway feel free to keep as it is, It's just a note that we can keep in mind in
future working on the CSS part.

[Thomas Greiner, 2016/01/25 18:41:24]

Done.

   top: 100px;
   left: 0px;
   right: 0px;
   z-index: 2;
   width: 400px;
+  margin: auto;
+  border-radius: 3px;
+  border: 2px solid #4D9D4B;
+  background-color: #FFFFFF;
 }
 
 #dialog header
 {
-  background-color: #4D9D4B;
   display: flex;
   min-height: 25px;
   padding: 10px;
+  background-color: #4D9D4B;
 }
 
 #dialog-close
 {
   -moz-border-start: 1px solid #25612B;
   -webkit-border-start: 1px solid #25612B;
   color: #0F660F;
   display: inline-block;
   height: 20px;
   font-size: 15px;
@@ skipping 91 matching lines @@
 body:not([data-dialog="language"]) #dialog-content-language,
 body:not([data-dialog="predefined"]) #dialog-title-predefined,
 body:not([data-dialog="predefined"]) #dialog-content-predefined,
 body:not([data-dialog]) #dialog
 {
   display: none;
 }
 
 #dialog-content-language .dialog-content-block
 {
   display: flex;

[saroyanm, 2016/01/25 16:32:37]

For some reason, RTL have a bug. It feels like caused by flex, but not really
sure.
When I go to "Add other language dialog" click on Add button I see an offset of
the UL element that contains the languages list.

[saroyanm, 2016/01/25 17:16:17]

Browser update, fixed the issue.

   flex-direction: column;
   height: 120px;
 }
 
 #dialog-content-language #other-language
 {
   height: 200px;
 }
 
 #other-language .button-add
@@ skipping 13 matching lines @@
 #other-language .button-add::before
 {
   display: none;
 }
 
 #other-language .display
 {
   -webkit-margin-start: 10px;
   -moz-margin-start: 10px;
 }