Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: packagerGecko.py

Issue 29333368: Issue 3498 - Improve file mapping / skipping logic (Closed)
Patch Set: Addressed Wladimir's feedback Created Jan. 12, 2016, 1:03 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packagerChrome.py ('k') | packagerSafari.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packagerGecko.py
diff --git a/packagerGecko.py b/packagerGecko.py
index 748bf2810e47663e26e9907c8dbdcfc47aeaff91..f07039a5c7d20ab9ccb436c43c652425b87d529f 100644
--- a/packagerGecko.py
+++ b/packagerGecko.py
@@ -338,12 +338,13 @@ def createBuild(baseDir, type="gecko", outFile=None, locales=None, buildNum=None
'multicompartment': multicompartment,
}
+ skip = metadata.options('mapping') if metadata.has_section('mapping') else []
files = Files(getPackageFiles(params), getIgnoredFiles(params),
process=lambda path, data: processFile(path, data, params))
files['install.rdf'] = createManifest(params)
if metadata.has_section('mapping'):
files.readMappedFiles(metadata.items('mapping'))
- files.read(baseDir, skip=('chrome'))
+ files.read(baseDir, skip=skip + ['chrome'])
for name, path in getChromeSubdirs(baseDir, params['locales']).iteritems():
if os.path.isdir(path):
files.read(path, 'chrome/%s' % name)
Wladimir Palant 2016/01/12 13:17:06 Same skip parameter has to be specified here as we
kzar 2016/01/12 13:26:03 Done.
« no previous file with comments | « packagerChrome.py ('k') | packagerSafari.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld