Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: packager.py

Issue 29333368: Issue 3498 - Improve file mapping / skipping logic (Closed)
Patch Set: Fixed typo in Gecko packager Created Jan. 13, 2016, 11:10 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | packagerChrome.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packager.py
diff --git a/packager.py b/packager.py
index 71ac371faf5f11b623c99ff9ed3aebbc2f8ce747..7cf01736027521b3511091a3f7a2ebc4b6d8bca6 100644
--- a/packager.py
+++ b/packager.py
@@ -88,18 +88,17 @@ class Files(dict):
return False
return True
- def read(self, path, relpath='', skip=None):
+ def read(self, path, relpath='', skip=()):
if os.path.isdir(path):
for file in os.listdir(path):
name = relpath + ('/' if relpath != '' else '') + file
- if (skip == None or file not in skip) and self.isIncluded(name):
- self.read(os.path.join(path, file), name)
+ if name not in skip and self.isIncluded(name):
+ self.read(os.path.join(path, file), name, skip)
else:
with open(path, 'rb') as file:
if relpath in self:
print >>sys.stderr, 'Warning: File %s defined multiple times' % relpath
- else:
- self[relpath] = file.read()
+ self[relpath] = file.read()
def readMappedFiles(self, mappings):
for item in mappings:
« no previous file with comments | « no previous file | packagerChrome.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld