Issue 1950 - Fixed: Filter tooltip not shown for long filters

chrome/content/ui/sidebar.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 231 matching lines @@
   cacheStorage = null;
 }
 
 // Fills a box with text splitting it up into multiple lines if necessary
 function setMultilineContent(box, text, noRemove)
 {
   if (!noRemove)
     while (box.firstChild)
       box.removeChild(box.firstChild);
 
-  for (var i = 0; i < text.length; i += 80)
+  let lines = text.match(/.{1,80}/g);
+  if (lines.length > 6)

[Erik, 2016/01/29 04:29:31]

Same here, I think this should be  `if (lines.length > 7)`, otherwise it looks
good!

[Thomas Greiner, 2016/01/29 18:28:56]

Done.

   {
-    var description = document.createElement("description");
-    description.setAttribute("value", text.substr(i, 80));
+    // Text is too long to display in full so we cut out the middle part
+    lines = lines.slice(0,3).concat("\u2026", lines.slice(-3));
+  }
+
+  for (let line of lines)
+  {
+    let description = document.createElement("description");
+    description.setAttribute("value", line);
     box.appendChild(description);
   }
 }
 
 // Fill in tooltip data before showing it
 function fillInTooltip(e) {
   // Prevent tooltip from overlapping menu
   if (E("context").state == "open")
   {
     e.preventDefault();
@@ skipping 1043 matching lines @@
       return {tooltip: this.itemsDummyTooltip};
   },
 
   invalidateItem: function(item)
   {
     let row = this.data.indexOf(item);
     if (row >= 0)
       this.boxObject.invalidateRow(row);
   }
 }