Delta Between Two Patch Sets: pages/contributors.html
Issue 29334775:
Issue 2873 - Making contributor tables responsive (Closed)
Left Patch Set: Fixed whitespace
Created Feb. 5, 2016, 1:31 p.m.
Right Patch Set: Removed unnessisary changes and fixed spacing
Created Feb. 5, 2016, 6:38 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
no next file »
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 title=Adblock Plus - Contributor Credits | 1 title=Adblock Plus - Contributor Credits |
| 2 | 2 |
| 3 <head> | 3 <head> |
| 4 <style type="text/css"> | 4 <style type="text/css"> |
| 5 #content | 5 #content |
| 6 { | 6 { |
| 7 width: 980px; | 7 width: 980px; |
| 8 } | 8 } |
| 9 | 9 |
| 10 #pageactions | 10 #pageactions |
| 11 { | 11 { |
| 12 margin-left: 0; | 12 margin-left: 0; |
| 13 margin-right: 0; | 13 margin-right: 0; |
| 14 width: 100%; | 14 width: 100%; |
| 15 } | 15 } |
| 16 | 16 |
| 17 section | 17 section |
| 18 { | 18 { |
| 19 display: inline-block; | 19 display: inline-block; |
| 20 margin: 0 40px 0 0; | 20 margin: 0 40px 0 0; |
| 21 } | 21 } |
| 22 | 22 |
| 23 h3 | 23 h3 |
| 24 { | 24 { |
| 25 margin: 0px 0 10px 0; | 25 margin: 0px 0 10px 0; |
| 26 } | 26 } |
| 27 | 27 |
| 28 .contributors-table | 28 .contributors-table |
| 29 { | 29 { |
| 30 display: block; | |
| 31 margin: 0 0 40px 0; | 30 margin: 0 0 40px 0; |
| 32 border: 0; | 31 border: 0; |
| 33 } | 32 } |
| 34 | 33 |
| 35 .contributors-table td | 34 .contributors-table td |
| 36 { | 35 { |
| 37 padding: 10px 5px; | 36 padding: 10px 5px; |
| 38 min-width: 200px; | 37 min-width: 200px; |
| 39 border: 0; | 38 border: 0; |
| 40 } | 39 } |
| (...skipping 23 matching lines...) Expand all Loading... | |
| 64 height: 40px; | 63 height: 40px; |
| 65 padding: 10px 0 5px 0; | 64 padding: 10px 0 5px 0; |
| 66 vertical-align: bottom; | 65 vertical-align: bottom; |
| 67 } | 66 } |
| 68 | 67 |
| 69 .contributors-table tbody td | 68 .contributors-table tbody td |
| 70 { | 69 { |
| 71 padding: 5px 5px; | 70 padding: 5px 5px; |
| 72 } | 71 } |
| 73 | 72 |
| 74 @media(max-width: 980px) { | 73 @media(max-width: 980px) |
| 74 { | |
| 75 #content | 75 #content |
| 76 { | 76 { |
| 77 width: auto; | 77 width: auto; |
| 78 } | 78 } |
| 79 | |
| 79 section | 80 section |
| 80 { | 81 { |
| 81 display: block; | 82 display: block; |
| 82 margin: 0px; | 83 margin: 0px; |
| 83 } | 84 } |
| 85 | |
| 84 .contributors-table | 86 .contributors-table |
| 85 { | 87 { |
| 86 width: 100%; | 88 width: 100%; |
| 87 display: table; | 89 } |
|
saroyanm
2016/02/05 14:49:58
What about not changing the display value at all ?
juliandoucette
2016/02/05 18:38:24
Done.
| |
| 88 } | 90 |
| 89 .contributors-table td | 91 .contributors-table td |
| 90 { | 92 { |
| 91 font-size: 12px; | |
|
saroyanm
2016/02/05 14:49:57
I would avoid introducing similar cosmetic fixes,
juliandoucette
2016/02/05 18:38:24
Done.
| |
| 92 min-width: inherit; | 93 min-width: inherit; |
|
saroyanm
2016/02/05 14:49:57
Deatail: I think no need to inherit initial value,
juliandoucette
2016/02/05 18:38:24
Done.
| |
| 93 width: 50%; | 94 width: 50%; |
| 94 } | 95 } |
| 95 } | 96 } |
| 96 | 97 |
| 97 </style> | 98 </style> |
| 98 </head> | 99 </head> |
| 99 <section id="team"> | 100 <section id="team"> |
| 100 <h3>{{s1 Team}}</h3> | 101 <h3>{{s1 Team}}</h3> |
| 101 <table class="contributors-table" rules="groups"> | 102 <table class="contributors-table" rules="groups"> |
| 102 <thead> | 103 <thead> |
| (...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 274 <td>Nickolay Ponomarev</td> | 275 <td>Nickolay Ponomarev</td> |
| 275 <td>{{s44 Developer (performance)}}</td> | 276 <td>{{s44 Developer (performance)}}</td> |
| 276 </tr> | 277 </tr> |
| 277 <tr> | 278 <tr> |
| 278 <td>Sebastian Schmidt (yath)</td> | 279 <td>Sebastian Schmidt (yath)</td> |
| 279 <td>{{s45 Developer (Adblock Plus for Android bug fix)}}</td> | 280 <td>{{s45 Developer (Adblock Plus for Android bug fix)}}</td> |
| 280 </tr> | 281 </tr> |
| 281 </tbody> | 282 </tbody> |
| 282 </table> | 283 </table> |
| 283 </section> | 284 </section> |
| LEFT | RIGHT |
« no previous file
|
no next file »
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
