Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: pages/contributors.html

Issue 29334775: Issue 2873 - Making contributor tables responsive (Closed)
Patch Set: Created Jan. 27, 2016, 4:29 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pages/contributors.html
===================================================================
--- a/pages/contributors.html
+++ b/pages/contributors.html
@@ -4,7 +4,21 @@
<style type="text/css">
#content
{
- width: 980px;
+ position: relative;
+ overflow: auto;
+}
+
+@media(min-width: 980px)
+{
+ #content
+ {
+ width: 980px;
+ }
+}
+
+#content h3
+{
+ margin: 0px 0 10px 0;
saroyanm 2016/02/04 16:03:45 Detail: please make styling consistent by specifin
juliandoucette 2016/02/05 13:30:25 Done.
}
#pageactions
@@ -14,29 +28,44 @@
width: 100%;
}
-section
+#content > section
{
- display: inline-block;
- margin: 0 40px 0 0;
-}
-
-h3
-{
- margin: 0px 0 10px 0;
+ display: block;
+ float: left;
saroyanm 2016/02/04 16:03:45 Can't see reason why to use float in this case to
juliandoucette 2016/02/05 13:30:25 Done.
+ width: 50%;
+ margin-top: 1em;
saroyanm 2016/02/04 16:03:45 Detail: Please use px to make it consistent with o
juliandoucette 2016/02/05 13:30:25 Done.
}
.contributors-table
{
- display: block;
- margin: 0 0 40px 0;
+ width: 90%;
+}
+
+@media(max-width: 980px)
+{
+ #content > section
+ {
+ display: block;
saroyanm 2016/02/04 16:03:45 This float hack shouldn't be necessary if we will
juliandoucette 2016/02/05 13:30:25 Done.
+ float: none;
+ clear: both;
+ width: 100%;
+ }
+ .contributors-table
+ {
+ width: 100%;
+ }
+}
+
+.contributors-table
+{
border: 0;
}
.contributors-table td
{
padding: 10px 5px;
+ border: 0;
saroyanm 2016/02/04 16:03:45 Detail: please specify units.
juliandoucette 2016/02/05 13:30:25 Acknowledged. I just moved this line. I didn't ch
min-width: 200px;
- border: 0;
}
.contributors-table thead
@@ -70,6 +99,17 @@
{
padding: 5px 5px;
}
+
+@media(max-width: 460px)
+{
+ .contributors-table td
+ {
+ font-size: 12px;
+ min-width: 140px;
+ }
+}
+
+.contributors-table
</style>
</head>
<section id="team">
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld