Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/uninstall.js

Issue 29336255: Issue 3649 - Truncate notificationDownloadCount (Closed)
Patch Set: Addressed Sebastian's feedback Created Feb. 11, 2016, 2:43 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/uninstall.js
diff --git a/lib/uninstall.js b/lib/uninstall.js
index 3872e1cde76860e697cb24fb44005e182ddbfeef..18f6b463d8285d6473d992174750e1e691d3e5ad 100644
--- a/lib/uninstall.js
+++ b/lib/uninstall.js
@@ -30,6 +30,12 @@ function setUninstallURL()
search.push(key + "=" + encodeURIComponent(info[key]));
let downlCount = Prefs.notificationdata.downloadCount || 0;
+
+ // FIXME - Once the changes for issue #3650 land and are included we should
+ // remove this check. (The number will be already truncated for us.)
+ if (downlCount > 4)
+ downlCount = "4+";
+
search.push("notificationDownloadCount=" + encodeURIComponent(downlCount));
chrome.runtime.setUninstallURL(Utils.getDocLink("uninstalled") + "&" +
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld