Issue 3748 - Update URL Fixer dependency on buildtools to revision c92cc4e4a338 and make it E10S-co…

lib/typoNetError.js

 /*
  * This file is part of the URL Fixer,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * URL Fixer is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * URL Fixer is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 50 matching lines @@
 }
 
 let info = require("info");
 let processScript = info.addonRoot + "lib/child/typoNetError.js?" + Math.random();
 let messageManager = Cc["@mozilla.org/parentprocessmessagemanager;1"]
                        .getService(Ci.nsIProcessScriptLoader)
                        .QueryInterface(Ci.nsIMessageListenerManager)
                        .QueryInterface(Ci.nsIMessageBroadcaster);
 messageManager.loadProcessScript(processScript, true);
 
-onShutdown.add(() => {

[Thomas Greiner, 2016/03/08 12:34:44]

Coding style: Opening braces always go on their own line.

This applies everywhere where you call `onShutdown.add()`.

[Wladimir Palant, 2016/03/08 14:37:48]

That style makes relatively little sense when used with arrow functions and so
far we've been consistently putting the braces on the same line in this case.
Yes, I'm looking forward to automatic style checks...

[Thomas Greiner, 2016/03/11 17:49:21]

So we'll have yet another exception to that rule? I don't see how we can keep
this consistent.

[Wladimir Palant, 2016/03/13 21:56:52]

I consulted eslint and it thinks that this shouldn't be an exception.

[Thomas Greiner, 2016/03/14 11:06:29]

Thanks for checking. Note that this is also the case in
lib/child/typoNetError.js

[Wladimir Palant, 2016/03/14 14:19:36]

Heh, missed that due to misconfiguring eslint...

+onShutdown.add(() =>
+{
   messageManager.broadcastAsyncMessage("URLFixer:Shutdown", processScript);
   messageManager.removeDelayedProcessScript(processScript);
 });
 
 messageManager.addMessageListener("URLFixer:GetNetErrorOverlay",
     getNetErrorOverlay);
 messageManager.addMessageListener("URLFixer:UserCorrection",
     processCorrection);
-onShutdown.add(() => {
+onShutdown.add(() =>
+{
   messageManager.removeMessageListener("URLFixer:GetNetErrorOverlay",
       getNetErrorOverlay);
   messageManager.removeMessageListener("URLFixer:UserCorrection",
       processCorrection);
 });