Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: hgreview.py

Issue 29338099: Noissue - Fixed hg review bug, mail not being sent for new reviews (Closed)
Patch Set: Created March 10, 2016, 2:15 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: hgreview.py
===================================================================
--- a/hgreview.py
+++ b/hgreview.py
@@ -35,17 +35,17 @@ def review(ui, repo, *paths, **opts):
args = ['--oauth2', '--server', SERVER]
if ui.debugflag:
args.append('--noisy')
elif ui.verbose:
args.append('--verbose')
elif ui.quiet:
args.append('--quiet')
- if opts.get('issue') or opts.get('message'):
+ if not opts.get('issue') or opts.get('message'):
args.append('--send_mail')
if opts.get('revision') and opts.get('change'):
raise error.Abort('Ambiguous revision range, only one of --revision and --change can be specified.')
if opts.get('change'):
args.extend(['--rev', '{0}^:{0}'.format(opts['change'])])
elif opts.get('revision'):
args.extend(['--rev', opts['revision']])
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld