Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: safari/ext/background.js

Issue 29339112: Issue 3716 - Split up files stored in storage.local (Closed)
Patch Set: Modify Safari storage. Refactor chunk name creation. Add comments. Created March 31, 2016, 1:53 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/io.js ('K') | « lib/prefs.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: safari/ext/background.js
===================================================================
--- a/safari/ext/background.js
+++ b/safari/ext/background.js
@@ -705,10 +705,15 @@
setTimeout(callback, 0, items);
},
- set: function(key, value, callback)
+ set: function(items, callback)
{
- safari.extension.settings[key] = value;
-
+ for (let key in items)
+ {
+ if (items.hasOwnProperty(key))
Sebastian Noack 2016/03/31 14:08:53 I think it's safe to just skip this check. We neve
+ {
+ safari.extension.settings[key] = items[key];
+ }
+ }
if (callback)
setTimeout(callback, 0);
},
« lib/io.js ('K') | « lib/prefs.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld