Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: options.js

Issue 29339314: Issue 3870 - Rewrite legacy options page to use async messages (Closed)
Patch Set: Avoid another race condition Created April 7, 2016, 1:27 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « lib/notificationHelper.js ('k') | safari/ext/background.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 var backgroundPage = ext.backgroundPage.getWindow(); 18 "use strict";
19 var require = backgroundPage.require;
20 19
21 with(require("filterClasses")) 20 /**
21 * Creates a wrapping function used to conveniently send a type of message.
22 *
23 * @param {Object} baseMessage The part of the message that's always sent
24 * @param {..string} paramKeys Any message keys that have dynamic values. The
25 * returned function will take the corresponding
26 * values as arguments.
27 * @return The generated messaging function, optionally taking any values as
28 * specified by the paramKeys and finally an optional callback.
29 * (Although the value arguments are optional their index must be
30 * maintained. E.g. if you omit the first value you must omit the
31 * second too.)
32 */
33 function wrapper(baseMessage /* , [paramKeys] */)
22 { 34 {
23 this.Filter = Filter; 35 var paramKeys = [];
24 this.WhitelistFilter = WhitelistFilter; 36 for (var i = 1; i < arguments.length; i++)
37 paramKeys.push(arguments[i]);
38
39 return function(/* [paramValues], callback */)
40 {
41 var message = Object.create(null);
42 for (var key in baseMessage)
43 if (baseMessage.hasOwnProperty(key))
44 message[key] = baseMessage[key];
45
46 var paramValues = [];
47 var callback;
48
49 if (arguments.length > 0)
50 {
51 var lastArg = arguments[arguments.length - 1];
52 if (typeof lastArg == "function")
53 callback = lastArg;
54
55 for (var i = 0; i < arguments.length - (callback ? 1 : 0); i++)
56 message[paramKeys[i]] = arguments[i];
57 }
58
59 ext.backgroundPage.sendMessage(message, callback);
60 };
25 } 61 }
26 with(require("subscriptionClasses"))
27 {
28 this.Subscription = Subscription;
29 this.SpecialSubscription = SpecialSubscription;
30 this.DownloadableSubscription = DownloadableSubscription;
31 }
32 with(require("filterValidation"))
33 {
34 this.parseFilter = parseFilter;
35 this.parseFilters = parseFilters;
36 }
37 var FilterStorage = require("filterStorage").FilterStorage;
38 var FilterNotifier = require("filterNotifier").FilterNotifier;
39 var Prefs = require("prefs").Prefs;
40 var Synchronizer = require("synchronizer").Synchronizer;
41 var Utils = require("utils").Utils;
42 var NotificationStorage = require("notification").Notification;
43 var info = require("info");
44 62
45 // Loads options from localStorage and sets UI elements accordingly 63 var getDocLink = wrapper({type: "app.get", what: "doclink"}, "link");
64 var getInfo = wrapper({type: "app.get"}, "what");
65 var getPref = wrapper({type: "prefs.get"}, "key");
66 var togglePref = wrapper({type: "prefs.toggle"}, "key");
67 var getSubscriptions = wrapper({type: "subscriptions.get"},
68 "downloadable", "special");
69 var removeSubscription = wrapper({type: "subscriptions.remove"}, "url");
70 var addSubscription = wrapper({type: "subscriptions.add"},
71 "url", "title", "homepage");
72 var toggleSubscription = wrapper({type: "subscriptions.toggle"},
73 "url", "keepInstalled");
74 var updateSubscription = wrapper({type: "subscriptions.update"}, "url");
75 var importRawFilters = wrapper({type: "filters.importRaw"},
76 "text", "removeExisting");
77 var addFilter = wrapper({type: "filters.add"}, "text");
78 var getFilters = wrapper({type: "filters.get"}, "subscriptionUrl");
79 var removeFilter = wrapper({type: "filters.remove"}, "text");
80
81 var i18n = ext.i18n;
82 var whitelistedDomainRegexp = /^@@\|\|([^\/:]+)\^\$document$/;
83 var delayedSubscriptionSelection = null;
84
85 var acceptableAdsUrl;
86
87 // Loads options and sets UI elements accordingly
46 function loadOptions() 88 function loadOptions()
47 { 89 {
48 // Set page title to i18n version of "Adblock Plus Options" 90 // Set page title to i18n version of "Adblock Plus Options"
49 document.title = i18n.getMessage("options"); 91 document.title = i18n.getMessage("options");
50 92
51 // Set links 93 // Set links
52 $("#acceptableAdsLink").attr("href", Prefs.subscriptions_exceptionsurl); 94 getPref("subscriptions_exceptionsurl", function(url)
53 $("#acceptableAdsDocs").attr("href", Utils.getDocLink("acceptable_ads")); 95 {
54 setLinks("filter-must-follow-syntax", Utils.getDocLink("filterdoc")); 96 acceptableAdsUrl = url;
55 setLinks("found-a-bug", Utils.getDocLink(info.application + "_support")); 97 $("#acceptableAdsLink").attr("href", acceptableAdsUrl);
98 });
99 getDocLink("acceptable_ads", function(url)
100 {
101 $("#acceptableAdsDocs").attr("href", url);
102 });
103 getDocLink("filterdoc", function(url)
104 {
105 setLinks("filter-must-follow-syntax", url);
106 });
107 getInfo("application", function(application)
108 {
109 getInfo("platform", function(platform)
110 {
111 if (platform == "chromium" && application != "opera")
112 application = "chrome";
113
114 getDocLink(application + "_support", function(url)
115 {
116 setLinks("found-a-bug", url);
117 });
118 });
119 });
56 120
57 // Add event listeners 121 // Add event listeners
58 window.addEventListener("unload", unloadOptions, false);
59 $("#updateFilterLists").click(updateFilterLists); 122 $("#updateFilterLists").click(updateFilterLists);
60 $("#startSubscriptionSelection").click(startSubscriptionSelection); 123 $("#startSubscriptionSelection").click(startSubscriptionSelection);
61 $("#subscriptionSelector").change(updateSubscriptionSelection); 124 $("#subscriptionSelector").change(updateSubscriptionSelection);
62 $("#addSubscription").click(addSubscription); 125 $("#addSubscription").click(addSubscriptionClicked);
63 $("#acceptableAds").click(allowAcceptableAds); 126 $("#acceptableAds").click(toggleAcceptableAds);
64 $("#whitelistForm").submit(addWhitelistDomain); 127 $("#whitelistForm").submit(addWhitelistDomain);
65 $("#removeWhitelist").click(removeSelectedExcludedDomain); 128 $("#removeWhitelist").click(removeSelectedExcludedDomain);
66 $("#customFilterForm").submit(addTypedFilter); 129 $("#customFilterForm").submit(addTypedFilter);
67 $("#removeCustomFilter").click(removeSelectedFilters); 130 $("#removeCustomFilter").click(removeSelectedFilters);
68 $("#rawFiltersButton").click(toggleFiltersInRawFormat); 131 $("#rawFiltersButton").click(toggleFiltersInRawFormat);
69 $("#importRawFilters").click(importRawFiltersText); 132 $("#importRawFilters").click(importRawFiltersText);
70 133
71 FilterNotifier.on("load", reloadFilters);
72 FilterNotifier.on("subscription.title", onSubscriptionChange);
73 FilterNotifier.on("subscription.disabled", onSubscriptionChange);
74 FilterNotifier.on("subscription.homepage", onSubscriptionChange);
75 FilterNotifier.on("subscription.lastDownload", onSubscriptionChange);
76 FilterNotifier.on("subscription.downloadStatus", onSubscriptionChange);
77 FilterNotifier.on("subscription.added", onSubscriptionAdded);
78 FilterNotifier.on("subscription.removed", onSubscriptionRemoved);
79 FilterNotifier.on("filter.added", onFilterAdded);
80 FilterNotifier.on("filter.removed", onFilterRemoved);
81
82 // Display jQuery UI elements 134 // Display jQuery UI elements
83 $("#tabs").tabs(); 135 $("#tabs").tabs();
84 $("button").button(); 136 $("button").button();
85 $(".refreshButton").button("option", "icons", {primary: "ui-icon-refresh"}); 137 $(".refreshButton").button("option", "icons", {primary: "ui-icon-refresh"});
86 $(".addButton").button("option", "icons", {primary: "ui-icon-plus"}); 138 $(".addButton").button("option", "icons", {primary: "ui-icon-plus"});
87 $(".removeButton").button("option", "icons", {primary: "ui-icon-minus"}); 139 $(".removeButton").button("option", "icons", {primary: "ui-icon-minus"});
88 140
89 // Popuplate option checkboxes 141 // Popuplate option checkboxes
90 initCheckbox("shouldShowBlockElementMenu"); 142 initCheckbox("shouldShowBlockElementMenu");
91 initCheckbox("show_devtools_panel"); 143 initCheckbox("show_devtools_panel");
92 initCheckbox("shouldShowNotifications", { 144 initCheckbox("shouldShowNotifications", {
93 get: function() 145 key: "notifications_ignoredcategories",
146 get: function(ignoredcategories)
94 { 147 {
95 return Prefs.notifications_ignoredcategories.indexOf("*") == -1; 148 return ignoredcategories.indexOf("*") == -1;
96 },
97 toggle: function()
98 {
99 NotificationStorage.toggleIgnoreCategory("*");
100 return this.get();
101 } 149 }
102 }); 150 });
103 151
104 if (info.platform != "chromium") 152 getInfo("features", function(features)
105 document.getElementById("showDevtoolsPanelContainer").hidden = true; 153 {
106 if (!Prefs.notifications_showui) 154 if (!features.devToolsPanel)
107 document.getElementById("shouldShowNotificationsContainer").hidden = true; 155 document.getElementById("showDevtoolsPanelContainer").hidden = true;
156 });
157 getPref("notifications_showui", function(notifications_showui)
158 {
159 if (!notifications_showui)
160 document.getElementById("shouldShowNotificationsContainer").hidden = true;
161 });
108 162
109 ext.onMessage.addListener(onMessage); 163 // Register listeners in the background message responder
110 ext.backgroundPage.sendMessage({ 164 ext.backgroundPage.sendMessage({
111 type: "app.listen", 165 type: "app.listen",
112 filter: ["addSubscription"] 166 filter: ["addSubscription", "focusSection"]
167 });
168 ext.backgroundPage.sendMessage(
169 {
170 type: "filters.listen",
171 filter: ["added", "loaded", "removed"]
172 });
173 ext.backgroundPage.sendMessage(
174 {
175 type: "prefs.listen",
176 filter: ["notifications_ignoredcategories", "notifications_showui",
177 "safari_contentblocker", "show_devtools_panel",
178 "shouldShowBlockElementMenu"]
179 });
180 ext.backgroundPage.sendMessage(
181 {
182 type: "subscriptions.listen",
183 filter: ["added", "disabled", "homepage", "lastDownload", "removed",
184 "title", "downloadStatus", "downloading"]
113 }); 185 });
114 186
115 // Load recommended subscriptions 187 // Load recommended subscriptions
116 loadRecommendations(); 188 loadRecommendations();
117 189
118 // Show user's filters 190 // Show user's filters
119 reloadFilters(); 191 reloadFilters();
120 } 192 }
121 $(loadOptions); 193 $(loadOptions);
122 194
123 function onMessage(msg)
124 {
125 if (msg.type == "app.listen")
126 {
127 if (msg.action == "addSubscription")
128 {
129 var subscription = msg.args[0];
130 startSubscriptionSelection(subscription.title, subscription.url);
131 }
132 }
133 else if (msg.type == "focus-section")
134 {
135 var tabs = document.getElementsByClassName("ui-tabs-panel");
136 for (var i = 0; i < tabs.length; i++)
137 {
138 var found = tabs[i].querySelector("[data-section='" + msg.section + "']");
139 if (!found)
140 continue;
141
142 var previous = document.getElementsByClassName("focused");
143 if (previous.length > 0)
144 previous[0].classList.remove("focused");
145
146 var tab = $("[href='#" + tabs[i].id + "']");
147 $("#tabs").tabs("select", tab.parent().index());
148 found.classList.add("focused");
149 }
150 }
151 };
152
153 // Reloads the displayed subscriptions and filters 195 // Reloads the displayed subscriptions and filters
154 function reloadFilters() 196 function reloadFilters()
155 { 197 {
156 // Load user filter URLs 198 // Load user filter URLs
157 var container = document.getElementById("filterLists"); 199 var container = document.getElementById("filterLists");
158 while (container.lastChild) 200 while (container.lastChild)
159 container.removeChild(container.lastChild); 201 container.removeChild(container.lastChild);
160 202
161 var hasAcceptable = false; 203 getSubscriptions(true, false, function(subscriptions)
162 for (var i = 0; i < FilterStorage.subscriptions.length; i++)
163 { 204 {
164 var subscription = FilterStorage.subscriptions[i]; 205 for (var i = 0; i < subscriptions.length; i++)
165 if (subscription instanceof SpecialSubscription)
166 continue;
167
168 if (subscription.url == Prefs.subscriptions_exceptionsurl)
169 { 206 {
170 hasAcceptable = true; 207 var subscription = subscriptions[i];
171 continue; 208 if (subscription.url == acceptableAdsUrl)
209 $("#acceptableAds").prop("checked", !subscription.disabled);
210 else
211 addSubscriptionEntry(subscription);
172 } 212 }
173 213 });
174 addSubscriptionEntry(subscription);
175 }
176
177 $("#acceptableAds").prop("checked", hasAcceptable);
178 214
179 // User-entered filters 215 // User-entered filters
180 var userFilters = backgroundPage.getUserFilters(); 216 getSubscriptions(false, true, function(subscriptions)
181 populateList("userFiltersBox", userFilters.filters); 217 {
182 populateList("excludedDomainsBox", userFilters.exceptions); 218 clearListBox("userFiltersBox");
183 } 219 clearListBox("excludedDomainsBox");
184 220
185 // Cleans up when the options window is closed 221 for (var i = 0; i < subscriptions.length; i++)
186 function unloadOptions() 222 getFilters(subscriptions[i].url, function(filters)
187 { 223 {
188 FilterNotifier.off("load", reloadFilters); 224 for (var j = 0; j < filters.length; j++)
189 FilterNotifier.off("subscription.title", onSubscriptionChange); 225 {
190 FilterNotifier.off("subscription.disabled", onSubscriptionChange); 226 var filter = filters[j].text;
191 FilterNotifier.off("subscription.homepage", onSubscriptionChange); 227 if (whitelistedDomainRegexp.test(filter))
192 FilterNotifier.off("subscription.lastDownload", onSubscriptionChange); 228 appendToListBox("excludedDomainsBox", RegExp.$1);
193 FilterNotifier.off("subscription.downloadStatus", onSubscriptionChange); 229 else
194 FilterNotifier.off("subscription.added", onSubscriptionAdded); 230 appendToListBox("userFiltersBox", filter);
195 FilterNotifier.off("subscription.removed", onSubscriptionRemoved); 231 }
196 FilterNotifier.off("filter.added", onFilterAdded); 232 });
197 FilterNotifier.off("filter.removed", onFilterRemoved); 233 });
198 } 234 }
199 235
200 function initCheckbox(id, descriptor) 236 function initCheckbox(id, descriptor)
201 { 237 {
202 var checkbox = document.getElementById(id); 238 var checkbox = document.getElementById(id);
203 if (descriptor && descriptor.get) 239 var key = descriptor && descriptor.key || id;
204 checkbox.checked = descriptor.get(); 240 getPref(key, function(value)
205 else 241 {
206 checkbox.checked = Prefs[id]; 242 if (descriptor && descriptor.get)
243 checkbox.checked = descriptor.get(value);
244 else
245 checkbox.checked = value;
246 });
207 247
208 checkbox.addEventListener("click", function() 248 checkbox.addEventListener("click", function()
209 { 249 {
210 if (descriptor && descriptor.toggle) 250 if (descriptor && descriptor.toggle)
211 checkbox.checked = descriptor.toggle(); 251 checkbox.checked = descriptor.toggle();
212 252 togglePref(key);
213 Prefs[id] = checkbox.checked;
214 }, false); 253 }, false);
215 } 254 }
216 255
217 var delayedSubscriptionSelection = null;
218
219 function loadRecommendations() 256 function loadRecommendations()
220 { 257 {
221 fetch("subscriptions.xml") 258 fetch("subscriptions.xml")
222 .then(function(response) 259 .then(function(response)
223 { 260 {
224 return response.text(); 261 return response.text();
225 }) 262 })
226 .then(function(text) 263 .then(function(text)
227 { 264 {
228 var selectedIndex = 0; 265 var selectedIndex = 0;
229 var selectedPrefix = null; 266 var selectedPrefix = null;
230 var matchCount = 0; 267 var matchCount = 0;
231 268
232 var list = document.getElementById("subscriptionSelector"); 269 var list = document.getElementById("subscriptionSelector");
233 var doc = new DOMParser().parseFromString(text, "application/xml"); 270 var doc = new DOMParser().parseFromString(text, "application/xml");
234 var elements = doc.documentElement.getElementsByTagName("subscription"); 271 var elements = doc.documentElement.getElementsByTagName("subscription");
235 272
236 for (var i = 0; i < elements.length; i++) 273 for (var i = 0; i < elements.length; i++)
237 { 274 {
238 var element = elements[i]; 275 var element = elements[i];
239 var option = new Option(); 276 var option = new Option();
240 option.text = element.getAttribute("title") + " (" + 277 option.text = element.getAttribute("title") + " (" +
241 element.getAttribute("specialization") + ")"; 278 element.getAttribute("specialization") + ")";
242 option._data = { 279 option._data = {
243 title: element.getAttribute("title"), 280 title: element.getAttribute("title"),
244 url: element.getAttribute("url"), 281 url: element.getAttribute("url"),
245 homepage: element.getAttribute("homepage") 282 homepage: element.getAttribute("homepage")
246 }; 283 };
247 284
248 var prefixes = element.getAttribute("prefixes"); 285 var prefix = element.getAttribute("prefixes");
249 var prefix = Utils.checkLocalePrefixMatch(prefixes);
250 if (prefix) 286 if (prefix)
251 { 287 {
288 prefix = prefix.replace(/\W/g, "_");
252 option.style.fontWeight = "bold"; 289 option.style.fontWeight = "bold";
253 option.style.backgroundColor = "#E0FFE0"; 290 option.style.backgroundColor = "#E0FFE0";
254 option.style.color = "#000000"; 291 option.style.color = "#000000";
255 if (!selectedPrefix || selectedPrefix.length < prefix.length) 292 if (!selectedPrefix || selectedPrefix.length < prefix.length)
256 { 293 {
257 selectedIndex = i; 294 selectedIndex = i;
258 selectedPrefix = prefix; 295 selectedPrefix = prefix;
259 matchCount = 1; 296 matchCount = 1;
260 } 297 }
261 else if (selectedPrefix && selectedPrefix.length == prefix.length) 298 else if (selectedPrefix && selectedPrefix.length == prefix.length)
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
318 var data = list.options[list.selectedIndex]._data; 355 var data = list.options[list.selectedIndex]._data;
319 if (data) 356 if (data)
320 $("#customSubscriptionContainer").hide(); 357 $("#customSubscriptionContainer").hide();
321 else 358 else
322 { 359 {
323 $("#customSubscriptionContainer").show(); 360 $("#customSubscriptionContainer").show();
324 $("#customSubscriptionTitle").focus(); 361 $("#customSubscriptionTitle").focus();
325 } 362 }
326 } 363 }
327 364
328 function addSubscription() 365 function addSubscriptionClicked()
329 { 366 {
330 var list = document.getElementById("subscriptionSelector"); 367 var list = document.getElementById("subscriptionSelector");
331 var data = list.options[list.selectedIndex]._data; 368 var data = list.options[list.selectedIndex]._data;
332 if (data) 369 if (data)
333 doAddSubscription(data.url, data.title, data.homepage); 370 addSubscription(data.url, data.title, data.homepage);
334 else 371 else
335 { 372 {
336 var url = document.getElementById("customSubscriptionLocation").value.trim() ; 373 var url = document.getElementById("customSubscriptionLocation").value.trim() ;
337 if (!/^https?:/i.test(url)) 374 if (!/^https?:/i.test(url))
338 { 375 {
339 alert(i18n.getMessage("global_subscription_invalid_location")); 376 alert(i18n.getMessage("global_subscription_invalid_location"));
340 $("#customSubscriptionLocation").focus(); 377 $("#customSubscriptionLocation").focus();
341 return; 378 return;
342 } 379 }
343 380
344 var title = document.getElementById("customSubscriptionTitle").value.trim(); 381 var title = document.getElementById("customSubscriptionTitle").value.trim();
345 if (!title) 382 if (!title)
346 title = url; 383 title = url;
347 384
348 doAddSubscription(url, title, null); 385 addSubscription(url, title, null);
349 } 386 }
350 387
351 $("#addSubscriptionContainer").hide(); 388 $("#addSubscriptionContainer").hide();
352 $("#customSubscriptionContainer").hide(); 389 $("#customSubscriptionContainer").hide();
353 $("#addSubscriptionButton").show(); 390 $("#addSubscriptionButton").show();
354 } 391 }
355 392
356 function doAddSubscription(url, title, homepage) 393 function toggleAcceptableAds()
357 { 394 {
358 if (url in FilterStorage.knownSubscriptions) 395 toggleSubscription(acceptableAdsUrl, true);
359 return;
360
361 var subscription = Subscription.fromURL(url);
362 if (!subscription)
363 return;
364
365 subscription.title = title;
366 if (homepage)
367 subscription.homepage = homepage;
368 FilterStorage.addSubscription(subscription);
369
370 if (subscription instanceof DownloadableSubscription && !subscription.lastDown load)
371 Synchronizer.execute(subscription);
372 }
373
374 function allowAcceptableAds(event)
375 {
376 var subscription = Subscription.fromURL(Prefs.subscriptions_exceptionsurl);
377 if (!subscription)
378 return;
379
380 subscription.disabled = false;
381 subscription.title = "Allow non-intrusive advertising";
382 if ($("#acceptableAds").prop("checked"))
383 {
384 FilterStorage.addSubscription(subscription);
385 if (subscription instanceof DownloadableSubscription && !subscription.lastDo wnload)
386 Synchronizer.execute(subscription);
387 }
388 else
389 FilterStorage.removeSubscription(subscription);
390 } 396 }
391 397
392 function findSubscriptionElement(subscription) 398 function findSubscriptionElement(subscription)
393 { 399 {
394 var children = document.getElementById("filterLists").childNodes; 400 var children = document.getElementById("filterLists").childNodes;
395 for (var i = 0; i < children.length; i++) 401 for (var i = 0; i < children.length; i++)
396 if (children[i]._subscription == subscription) 402 if (children[i]._subscription.url == subscription.url)
397 return children[i]; 403 return children[i];
398 return null; 404 return null;
399 } 405 }
400 406
401 function updateSubscriptionInfo(element) 407 function updateSubscriptionInfo(element, subscription)
402 { 408 {
403 var subscription = element._subscription; 409 if (subscription)
410 element._subscription = subscription;
411 else
412 subscription = element._subscription;
404 413
405 var title = element.getElementsByClassName("subscriptionTitle")[0]; 414 var title = element.getElementsByClassName("subscriptionTitle")[0];
406 title.textContent = subscription.title; 415 title.textContent = subscription.title;
407 title.setAttribute("title", subscription.url); 416 title.setAttribute("title", subscription.url);
408 if (subscription.homepage) 417 if (subscription.homepage)
409 title.href = subscription.homepage; 418 title.href = subscription.homepage;
410 else 419 else
411 title.href = subscription.url; 420 title.href = subscription.url;
412 421
413 var enabled = element.getElementsByClassName("subscriptionEnabled")[0]; 422 var enabled = element.getElementsByClassName("subscriptionEnabled")[0];
414 enabled.checked = !subscription.disabled; 423 enabled.checked = !subscription.disabled;
415 424
416 var lastUpdate = element.getElementsByClassName("subscriptionUpdate")[0]; 425 var lastUpdate = element.getElementsByClassName("subscriptionUpdate")[0];
417 lastUpdate.classList.remove("error"); 426 lastUpdate.classList.remove("error");
418 if (Synchronizer.isExecuting(subscription.url)) 427
428 var downloadStatus = subscription.downloadStatus;
429 if (subscription.isDownloading)
430 {
419 lastUpdate.textContent = i18n.getMessage("filters_subscription_lastDownload_ inProgress"); 431 lastUpdate.textContent = i18n.getMessage("filters_subscription_lastDownload_ inProgress");
420 else if (subscription.downloadStatus && subscription.downloadStatus != "synchr onize_ok") 432 }
433 else if (downloadStatus && downloadStatus != "synchronize_ok")
421 { 434 {
422 var map = 435 var map =
423 { 436 {
424 "synchronize_invalid_url": "filters_subscription_lastDownload_invalidURL", 437 "synchronize_invalid_url": "filters_subscription_lastDownload_invalidURL" ,
425 "synchronize_connection_error": "filters_subscription_lastDownload_connect ionError", 438 "synchronize_connection_error": "filters_subscription_lastDownload_connec tionError",
426 "synchronize_invalid_data": "filters_subscription_lastDownload_invalidData ", 439 "synchronize_invalid_data": "filters_subscription_lastDownload_invalidDat a",
427 "synchronize_checksum_mismatch": "filters_subscription_lastDownload_checks umMismatch" 440 "synchronize_checksum_mismatch": "filters_subscription_lastDownload_check sumMismatch"
428 }; 441 };
429 if (subscription.downloadStatus in map) 442 if (downloadStatus in map)
430 lastUpdate.textContent = i18n.getMessage(map[subscription.downloadStatus]) ; 443 lastUpdate.textContent = i18n.getMessage(map[downloadStatus]);
431 else 444 else
432 lastUpdate.textContent = subscription.downloadStatus; 445 lastUpdate.textContent = downloadStatus;
433 lastUpdate.classList.add("error"); 446 lastUpdate.classList.add("error");
434 } 447 }
435 else if (subscription.lastDownload > 0) 448 else if (subscription.lastDownload > 0)
436 { 449 {
437 var timeDate = i18n_timeDateStrings(subscription.lastDownload * 1000); 450 var timeDate = i18n_timeDateStrings(subscription.lastDownload * 1000);
438 var messageID = (timeDate[1] ? "last_updated_at" : "last_updated_at_today"); 451 var messageID = (timeDate[1] ? "last_updated_at" : "last_updated_at_today");
439 lastUpdate.textContent = i18n.getMessage(messageID, timeDate); 452 lastUpdate.textContent = i18n.getMessage(messageID, timeDate);
440 } 453 }
441 } 454 }
442 455
443 function onSubscriptionChange(subscription) 456 function onSubscriptionMessage(action, subscription)
444 { 457 {
445 var element = findSubscriptionElement(subscription); 458 var element = findSubscriptionElement(subscription);
446 if (element)
447 updateSubscriptionInfo(element);
448 }
449 459
450 function onSubscriptionAdded(subscription) 460 switch (action)
451 {
452 if (subscription instanceof SpecialSubscription)
453 { 461 {
454 for (var i = 0; i < subscription.filters.length; i++) 462 case "disabled":
455 onFilterAdded(subscription.filters[i]); 463 case "downloading":
456 } 464 case "downloadStatus":
457 else if (subscription.url == Prefs.subscriptions_exceptionsurl) 465 case "homepage":
458 $("#acceptableAds").prop("checked", true); 466 case "lastDownload":
459 else if (!findSubscriptionElement(subscription)) 467 case "title":
460 addSubscriptionEntry(subscription); 468 if (element)
461 } 469 updateSubscriptionInfo(element, subscription);
462 470 break;
463 function onSubscriptionRemoved(subscription) 471 case "added":
464 { 472 if (subscription.url == acceptableAdsUrl)
465 if (subscription instanceof SpecialSubscription) 473 $("#acceptableAds").prop("checked", true);
466 { 474 else if (!element)
467 for (var i = 0; i < subscription.filters.length; i++) 475 addSubscriptionEntry(subscription);
468 onFilterRemoved(subscription.filters[i]); 476 break;
469 } 477 case "removed":
470 else if (subscription.url == Prefs.subscriptions_exceptionsurl) 478 if (subscription.url == acceptableAdsUrl)
471 $("#acceptableAds").prop("checked", false); 479 $("#acceptableAds").prop("checked", false);
472 else 480 else if (element)
473 { 481 element.parentNode.removeChild(element);
474 var element = findSubscriptionElement(subscription); 482 break;
475 if (element)
476 element.parentNode.removeChild(element);
477 } 483 }
478 } 484 }
479 485
480 function onFilterAdded(filter) 486 function onPrefMessage(key, value)
481 { 487 {
482 if (filter instanceof WhitelistFilter && 488 switch (key)
483 /^@@\|\|([^\/:]+)\^\$document$/.test(filter.text)) 489 {
484 appendToListBox("excludedDomainsBox", RegExp.$1); 490 case "notifications_showui":
485 else 491 document.getElementById("shouldShowNotificationsContainer").hidden = !valu e;
486 appendToListBox("userFiltersBox", filter.text); 492 return;
493 case "notifications_ignoredcategories":
494 key = "shouldShowNotifications";
495 value = value.indexOf("*") == -1;
496 break;
497 }
498
499 var checkbox = document.getElementById(key);
500 if (checkbox)
501 checkbox.checked = value;
487 } 502 }
488 503
489 function onFilterRemoved(filter) 504 function onFilterMessage(action, filter)
490 { 505 {
491 if (filter instanceof WhitelistFilter && 506 switch (action)
492 /^@@\|\|([^\/:]+)\^\$document$/.test(filter.text)) 507 {
493 removeFromListBox("excludedDomainsBox", RegExp.$1); 508 case "loaded":
494 else 509 reloadFilters();
495 removeFromListBox("userFiltersBox", filter.text); 510 break;
511 case "added":
512 if (whitelistedDomainRegexp.test(filter.text))
513 appendToListBox("excludedDomainsBox", RegExp.$1);
514 else
515 appendToListBox("userFiltersBox", filter.text);
516 break;
517 case "removed":
518 if (whitelistedDomainRegexp.test(filter.text))
519 removeFromListBox("excludedDomainsBox", RegExp.$1);
520 else
521 removeFromListBox("userFiltersBox", filter.text);
522 break;
523 }
496 } 524 }
497 525
498 // Populates a list box with a number of entries 526 function clearListBox(id)
499 function populateList(id, entries)
500 { 527 {
501 var list = document.getElementById(id); 528 var list = document.getElementById(id);
502 while (list.lastChild) 529 while (list.lastChild)
503 list.removeChild(list.lastChild); 530 list.removeChild(list.lastChild);
504
505 entries.sort();
506 for (var i = 0; i < entries.length; i++)
507 {
508 var option = new Option();
509 option.text = entries[i];
510 option.value = entries[i];
511 list.appendChild(option);
512 }
513 } 531 }
514 532
515 // Add a filter string to the list box. 533 // Add a filter string to the list box.
516 function appendToListBox(boxId, text) 534 function appendToListBox(boxId, text)
517 { 535 {
518 var elt = new Option(); /* Note: document.createElement("option") is unreliab le in Opera */ 536 // Note: document.createElement("option") is unreliable in Opera
537 var elt = new Option();
519 elt.text = text; 538 elt.text = text;
520 elt.value = text; 539 elt.value = text;
521 document.getElementById(boxId).appendChild(elt); 540 document.getElementById(boxId).appendChild(elt);
522 } 541 }
523 542
524 // Remove a filter string from a list box. 543 // Remove a filter string from a list box.
525 function removeFromListBox(boxId, text) 544 function removeFromListBox(boxId, text)
526 { 545 {
527 var list = document.getElementById(boxId); 546 var list = document.getElementById(boxId);
528 for (var i = 0; i < list.length; i++) 547 for (var i = 0; i < list.length; i++)
529 if (list.options[i].value == text) 548 if (list.options[i].value == text)
530 list.remove(i--); 549 list.remove(i--);
531 } 550 }
532 551
533 function addWhitelistDomain(event) 552 function addWhitelistDomain(event)
534 { 553 {
535 event.preventDefault(); 554 event.preventDefault();
536 555
537 var domain = document.getElementById("newWhitelistDomain").value.replace(/\s/g , ""); 556 var domain = document.getElementById("newWhitelistDomain").value.replace(/\s/g , "");
538 document.getElementById("newWhitelistDomain").value = ""; 557 document.getElementById("newWhitelistDomain").value = "";
539 if (!domain) 558 if (!domain)
540 return; 559 return;
541 560
542 var filterText = "@@||" + domain + "^$document"; 561 var filterText = "@@||" + domain + "^$document";
543 FilterStorage.addFilter(Filter.fromText(filterText)); 562 addFilter(filterText);
544 } 563 }
545 564
546 // Adds filter text that user typed to the selection box 565 // Adds filter text that user typed to the selection box
547 function addTypedFilter(event) 566 function addTypedFilter(event)
548 { 567 {
549 event.preventDefault(); 568 event.preventDefault();
550 569
551 var element = document.getElementById("newFilter"); 570 var element = document.getElementById("newFilter");
552 var result = parseFilter(element.value); 571 addFilter(element.value, function(errors)
553
554 if (result.error)
555 { 572 {
556 alert(result.error); 573 if (errors.length > 0)
557 return; 574 alert(errors.join("\n"));
558 } 575 else
559 576 element.value = "";
560 if (result.filter) 577 });
561 FilterStorage.addFilter(result.filter);
562
563 element.value = "";
564 } 578 }
565 579
566 // Removes currently selected whitelisted domains 580 // Removes currently selected whitelisted domains
567 function removeSelectedExcludedDomain(event) 581 function removeSelectedExcludedDomain(event)
568 { 582 {
569 event.preventDefault(); 583 event.preventDefault();
570 var excludedDomainsBox = document.getElementById("excludedDomainsBox"); 584 var excludedDomainsBox = document.getElementById("excludedDomainsBox");
571 var remove = []; 585 var remove = [];
572 for (var i = 0; i < excludedDomainsBox.length; i++) 586 for (var i = 0; i < excludedDomainsBox.length; i++)
573 if (excludedDomainsBox.options[i].selected) 587 if (excludedDomainsBox.options[i].selected)
574 remove.push(excludedDomainsBox.options[i].value); 588 remove.push(excludedDomainsBox.options[i].value);
575 if (!remove.length) 589 if (!remove.length)
576 return; 590 return;
577 591
578 for (var i = 0; i < remove.length; i++) 592 for (var i = 0; i < remove.length; i++)
579 FilterStorage.removeFilter(Filter.fromText("@@||" + remove[i] + "^$document" )); 593 removeFilter("@@||" + remove[i] + "^$document");
580 } 594 }
581 595
582 // Removes all currently selected filters 596 // Removes all currently selected filters
583 function removeSelectedFilters(event) 597 function removeSelectedFilters(event)
584 { 598 {
585 event.preventDefault(); 599 event.preventDefault();
586 var userFiltersBox = document.getElementById("userFiltersBox"); 600 var userFiltersBox = document.getElementById("userFiltersBox");
587 var remove = []; 601 var remove = [];
588 for (var i = 0; i < userFiltersBox.length; i++) 602 for (var i = 0; i < userFiltersBox.length; i++)
589 if (userFiltersBox.options[i].selected) 603 if (userFiltersBox.options[i].selected)
590 remove.push(userFiltersBox.options[i].value); 604 remove.push(userFiltersBox.options[i].value);
591 if (!remove.length) 605 if (!remove.length)
592 return; 606 return;
593 607
594 for (var i = 0; i < remove.length; i++) 608 for (var i = 0; i < remove.length; i++)
595 FilterStorage.removeFilter(Filter.fromText(remove[i])); 609 removeFilter(remove[i]);
596 } 610 }
597 611
598 // Shows raw filters box and fills it with the current user filters 612 // Shows raw filters box and fills it with the current user filters
599 function toggleFiltersInRawFormat(event) 613 function toggleFiltersInRawFormat(event)
600 { 614 {
601 event.preventDefault(); 615 event.preventDefault();
602 616
603 $("#rawFilters").toggle(); 617 $("#rawFilters").toggle();
604 if ($("#rawFilters").is(":visible")) 618 if ($("#rawFilters").is(":visible"))
605 { 619 {
606 var userFiltersBox = document.getElementById("userFiltersBox"); 620 var userFiltersBox = document.getElementById("userFiltersBox");
607 var text = ""; 621 var text = "";
608 for (var i = 0; i < userFiltersBox.length; i++) 622 for (var i = 0; i < userFiltersBox.length; i++)
609 text += userFiltersBox.options[i].value + "\n"; 623 text += userFiltersBox.options[i].value + "\n";
610 document.getElementById("rawFiltersText").value = text; 624 document.getElementById("rawFiltersText").value = text;
611 } 625 }
612 } 626 }
613 627
614 // Imports filters in the raw text box 628 // Imports filters in the raw text box
615 function importRawFiltersText() 629 function importRawFiltersText()
616 { 630 {
617 var text = document.getElementById("rawFiltersText").value; 631 var text = document.getElementById("rawFiltersText").value;
618 var result = parseFilters(text);
619 632
620 var errors = result.errors.filter(function(e) 633 importRawFilters(text, true, function(errors)
621 { 634 {
622 return e.type != "unexpected-filter-list-header"; 635 if (errors.length > 0)
636 alert(errors.join("\n"));
637 else
638 $("#rawFilters").hide();
623 }); 639 });
624
625 if (errors.length > 0)
626 {
627 alert(errors.join("\n"));
628 return;
629 }
630
631 var seenFilter = Object.create(null);
632 for (var i = 0; i < result.filters.length; i++)
633 {
634 var filter = result.filters[i];
635 FilterStorage.addFilter(filter);
636 seenFilter[filter.text] = null;
637 }
638
639 var remove = [];
640 for (var i = 0; i < FilterStorage.subscriptions.length; i++)
641 {
642 var subscription = FilterStorage.subscriptions[i];
643 if (!(subscription instanceof SpecialSubscription))
644 continue;
645
646 for (var j = 0; j < subscription.filters.length; j++)
647 {
648 var filter = subscription.filters[j];
649 if (filter instanceof WhitelistFilter && /^@@\|\|([^\/:]+)\^\$document$/.t est(filter.text))
650 continue;
651
652 if (!(filter.text in seenFilter))
653 remove.push(filter);
654 }
655 }
656
657 for (var i = 0; i < remove.length; i++)
658 FilterStorage.removeFilter(remove[i]);
659
660 $("#rawFilters").hide();
661 } 640 }
662 641
663 // Called when user explicitly requests filter list updates 642 // Called when user explicitly requests filter list updates
664 function updateFilterLists() 643 function updateFilterLists()
665 { 644 {
666 for (var i = 0; i < FilterStorage.subscriptions.length; i++) 645 // Without the URL parameter this will update all subscriptions
667 { 646 updateSubscription();
668 var subscription = FilterStorage.subscriptions[i];
669 if (subscription instanceof DownloadableSubscription)
670 Synchronizer.execute(subscription, true, true);
671 }
672 } 647 }
673 648
674 // Adds a subscription entry to the UI. 649 // Adds a subscription entry to the UI.
675 function addSubscriptionEntry(subscription) 650 function addSubscriptionEntry(subscription)
676 { 651 {
677 var template = document.getElementById("subscriptionTemplate"); 652 var template = document.getElementById("subscriptionTemplate");
678 var element = template.cloneNode(true); 653 var element = template.cloneNode(true);
679 element.removeAttribute("id"); 654 element.removeAttribute("id");
680 element._subscription = subscription; 655 element._subscription = subscription;
681 656
682 var removeButton = element.getElementsByClassName("subscriptionRemoveButton")[ 0]; 657 var removeButton = element.getElementsByClassName("subscriptionRemoveButton")[ 0];
683 removeButton.setAttribute("title", removeButton.textContent); 658 removeButton.setAttribute("title", removeButton.textContent);
684 removeButton.textContent = "\xD7"; 659 removeButton.textContent = "\xD7";
685 removeButton.addEventListener("click", function() 660 removeButton.addEventListener("click", function()
686 { 661 {
687 if (!confirm(i18n.getMessage("global_remove_subscription_warning"))) 662 if (!confirm(i18n.getMessage("global_remove_subscription_warning")))
688 return; 663 return;
689 664
690 FilterStorage.removeSubscription(subscription); 665 removeSubscription(subscription.url);
691 }, false); 666 }, false);
692 if (Prefs.additional_subscriptions.indexOf(subscription.url) != -1) 667
693 removeButton.style.visibility = "hidden"; 668 getPref("additional_subscriptions", function(additionalSubscriptions)
669 {
670 if (additionalSubscriptions.indexOf(subscription.url) != -1)
671 removeButton.style.visibility = "hidden";
672 });
694 673
695 var enabled = element.getElementsByClassName("subscriptionEnabled")[0]; 674 var enabled = element.getElementsByClassName("subscriptionEnabled")[0];
696 enabled.addEventListener("click", function() 675 enabled.addEventListener("click", function()
697 { 676 {
698 if (subscription.disabled == !enabled.checked) 677 subscription.disabled = !subscription.disabled;
699 return; 678 toggleSubscription(subscription.url, true);
700
701 subscription.disabled = !enabled.checked;
702 }, false); 679 }, false);
703 680
704 updateSubscriptionInfo(element); 681 updateSubscriptionInfo(element);
705 682
706 document.getElementById("filterLists").appendChild(element); 683 document.getElementById("filterLists").appendChild(element);
707 } 684 }
708 685
709 function setLinks(id) 686 function setLinks(id)
710 { 687 {
711 var element = document.getElementById(id); 688 var element = document.getElementById(id);
712 if (!element) 689 if (!element)
713 return; 690 return;
714 691
715 var links = element.getElementsByTagName("a"); 692 var links = element.getElementsByTagName("a");
716 for (var i = 0; i < links.length; i++) 693 for (var i = 0; i < links.length; i++)
717 { 694 {
718 if (typeof arguments[i + 1] == "string") 695 if (typeof arguments[i + 1] == "string")
719 { 696 {
720 links[i].href = arguments[i + 1]; 697 links[i].href = arguments[i + 1];
721 links[i].setAttribute("target", "_blank"); 698 links[i].setAttribute("target", "_blank");
722 } 699 }
723 else if (typeof arguments[i + 1] == "function") 700 else if (typeof arguments[i + 1] == "function")
724 { 701 {
725 links[i].href = "javascript:void(0);"; 702 links[i].href = "javascript:void(0);";
726 links[i].addEventListener("click", arguments[i + 1], false); 703 links[i].addEventListener("click", arguments[i + 1], false);
727 } 704 }
728 } 705 }
729 } 706 }
707
708 ext.onMessage.addListener(function(message)
709 {
710 switch (message.type)
711 {
712 case "app.respond":
713 switch (message.action)
714 {
715 case "addSubscription":
716 var subscription = message.args[0];
717 startSubscriptionSelection(subscription.title, subscription.url);
718 break;
719 case "focusSection":
720 var tabs = document.getElementsByClassName("ui-tabs-panel");
721 for (var i = 0; i < tabs.length; i++)
722 {
723 var found = tabs[i].querySelector(
724 "[data-section='" + message.args[0] + "']"
725 );
726 if (!found)
727 continue;
728
729 var previous = document.getElementsByClassName("focused");
730 if (previous.length > 0)
731 previous[0].classList.remove("focused");
732
733 var tab = $("[href='#" + tabs[i].id + "']");
734 $("#tabs").tabs("select", tab.parent().index());
735 found.classList.add("focused");
736 }
737 break;
738 }
739 break;
740 case "filters.respond":
741 onFilterMessage(message.action, message.args[0]);
742 break;
743 case "prefs.respond":
744 onPrefMessage(message.action, message.args[0]);
745 break;
746 case "subscriptions.respond":
747 onSubscriptionMessage(message.action, message.args[0]);
748 break;
749 }
750 });
OLDNEW
« no previous file with comments | « lib/notificationHelper.js ('k') | safari/ext/background.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld