lib/utils.js - Issue 29339346: Noissue - Removed obsolete nsIURI compatbility code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/utils.js

Issue 29339346: Noissue - Removed obsolete nsIURI compatbility code (Closed)

Patch Set: Created April 4, 2016, 11:20 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/utils.js

===================================================================

--- a/lib/utils.js

+++ b/lib/utils.js

@@ -55,9 +55,22 @@

makeURI: function(url)

{

- return Services.io.newURI(url);

+ let urlObj;

+ try

+ {

+ urlObj = new URL(url);

+ }

+ catch (e)

Sebastian Noack 2016/04/04 11:22:26 We previously didn't handle exceptions here, but w

+ {

+ return null;

+ }

+ return {

+ spec: urlObj.href,

+ scheme: urlObj.protocol,

+ host: urlObj.hostname

+ };

checkLocalePrefixMatch: function(prefixes)

{

if (!prefixes)

« lib/compat.js ('K') | « lib/compat.js ('k') | no next file » | no next file with comments »