static/css/main.css - Issue 29340844: Issue 3802 - Create page to inform users about adware on web.adblockplus.org

Side by Side Diff: static/css/main.css

Issue 29340844: Issue 3802 - Create page to inform users about adware on web.adblockplus.org (Closed)

Patch Set: Fixed meta translations Created May 24, 2016, 12:12 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 *	1 *

2 {	2 {

3 font-family: Arial, sans;	3 font-family: Arial, sans;

4 font-size: 16px;	4 font-size: 16px;

5 }	5 }

6	6

7 body	7 body

8 {	8 {

9 background-color: #f8f6f2;	9 background-color: #f8f6f2;

10 background-image: url(../img/background.png);	10 background-image: url(../img/background.png);

(...skipping 397 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
408	408

409 div.animation[started="false"]	409 div.animation[started="false"]

410 {	410 {

411 cursor: pointer;	411 cursor: pointer;

412 }	412 }

413	413

414 div.animation[started="true"]	414 div.animation[started="true"]

415 {	415 {

416 -moz-user-select: none;	416 -moz-user-select: none;

417 }	417 }

	418
	saroyanm 2016/05/31 15:23:35 This styles are for just a custom page we have, do This styles are for just a custom page we have, doesn't make sense to load them for every page we have now. They do not belong here IMO: You can still use. <head> <style type="text/css"> </style> </head> In adware.md to apply custom styles for specific page. juliandoucette 2016/05/31 19:27:46 I'm not sure: - by your logic, what styles do Show quoted text On 2016/05/31 15:23:35, saroyanm wrote: > This styles are for just a custom page we have, doesn't make sense to load them > for every page we have now. They do not belong here IMO: > You can still use. > <head> > <style type="text/css"> > </style> > </head> > > In adware.md to apply custom styles for specific page. I'm not sure: - by your logic, what styles do belong in main.css? - I thought that these styles were mostly general/basic enough - aren't we trying to avoid putting many styles inside pages because pages are meant to be _content_ and not _code_? saroyanm 2016/06/01 14:38:01 That's true and would be great not to have too man Show quoted text On 2016/05/31 19:27:46, juliandoucette wrote: > On 2016/05/31 15:23:35, saroyanm wrote: > > This styles are for just a custom page we have, doesn't make sense to load > them > > for every page we have now. They do not belong here IMO: > > You can still use. > > <head> > > <style type="text/css"> > > </style> > > </head> > > > > In adware.md to apply custom styles for specific page. > > I'm not sure: > > - by your logic, what styles do belong in main.css? > - I thought that these styles were mostly general/basic enough > - aren't we trying to avoid putting many styles inside pages because pages are > meant to be _content_ and not _code_? That's true and would be great not to have too many custom styles for specific page, but while it's only this page I think we need to make it custom, but if we will start to use that styles on other pages we can move them to main.css, or create separate template for specific pages in case it's only general for them, but while web.adblockplus.org is messy, we need try not to provide more mess, so I think it's better to keep the style for this custom case I think. So for future projects we will need to understand what kind of element specific pages need to use and create specific template for them, in case of web.adblockplus.org it's hard to find good balance and in the end after content migration to help center we will need to think about the redesign and clearing the mess :) juliandoucette 2016/06/01 16:23:19 Done. Show quoted text On 2016/06/01 14:38:01, saroyanm wrote: > On 2016/05/31 19:27:46, juliandoucette wrote: > > On 2016/05/31 15:23:35, saroyanm wrote: > > > This styles are for just a custom page we have, doesn't make sense to load > > them > > > for every page we have now. They do not belong here IMO: > > > You can still use. > > > <head> > > > <style type="text/css"> > > > </style> > > > </head> > > > > > > In adware.md to apply custom styles for specific page. > > > > I'm not sure: > > > > - by your logic, what styles do belong in main.css? > > - I thought that these styles were mostly general/basic enough > > - aren't we trying to avoid putting many styles inside pages because pages are > > meant to be _content_ and not _code_? > > That's true and would be great not to have too many custom styles for specific > page, but while it's only this page I think we need to make it custom, but if we > will start to use that styles on other pages we can move them to main.css, or > create separate template for specific pages in case it's only general for them, > but while http://web.adblockplus.org is messy, we need try not to provide more mess, so > I think it's better to keep the style for this custom case I think. > > So for future projects we will need to understand what kind of element specific > pages need to use and create specific template for them, in case of > http://web.adblockplus.org it's hard to find good balance and in the end after content > migration to help center we will need to think about the redesign and clearing > the mess :) Done.
	419 .split-section {
	saroyanm 2016/05/31 15:23:35 detail: "Opening braces always go on their own lin detail: "Opening braces always go on their own line" according to our coding style, same applies to the styles below. juliandoucette 2016/05/31 19:27:46 Done. Sorry about that :/ Show quoted text On 2016/05/31 15:23:35, saroyanm wrote: > detail: "Opening braces always go on their own line" according to our coding > style, same applies to the styles below. Done. Sorry about that :/
	420 margin-top: 20px;

	421 padding-top: 20px;

	422 border-top: 1px solid #ccc;

	423 }

	424

	425 .narrow-list {

	426 display: inline-block;

	427 width: 250px;

	428 margin: 0 35px 10px 0px;
	saroyanm 2016/05/31 15:23:35 detail: "CSS number values should specify units wh detail: "CSS number values should specify units where possible" according to our coding style, same applies to the styles below. juliandoucette 2016/05/31 19:27:46 Done. Sorry about that :/ Show quoted text On 2016/05/31 15:23:35, saroyanm wrote: > detail: "CSS number values should specify units where possible" according to > our coding style, same applies to the styles below. Done. Sorry about that :/
	429 vertical-align: top;

	430 }

	431

	432 .narrow-list ul {

	433 margin-bottom: 0;

	434 }

	435

	436 .text-danger

	437 {

	438 color: #e11a2c

	439 }

	440

	441 .alert-danger

	442 {

	443 padding: 15px;

	444 border: 2px solid;

	445 border-color: #e11a2c;

	446 background-color: #fff;

	447 }

	448

	449 .badge-header

	450 {

	451 vertical-align: middle;

	452 line-height: 34px;

	453 }

	454

	455 .badge-success

	456 {

	457 display: inline-block;

	458 vertical-align: top;

	459 text-align: center;

	460 line-height: 20px;

	461 margin-right: 7px;

	462 padding: 7px 0px;

	463 width: 34px;

	464 border-radius: 4px;

	465 color: #fff;

	466 background-color: #53b044;

	467 font-weight: bold;

	468 font-size: 20px;

	469 }

	470

	471 .list-unstyled,

	472 .list-unstyled li

	473 {

	474 margin-left: 0px;

	475 padding-left: 0px;

	476 }

	477

	478 .list-unstyled li

	479 {

	480 list-style-type: none;

	481 }

	482

	483 .list-unstyled li

	484 {

	485 padding-bottom: 10px;

	486 line-height: 20px;

	487 }

	488

	489 .list-custom {

	490 padding-left: 0;

	491 overflow: visible;

	492 list-style-type: none;

	493 }

	494

	495 .list-custom ul {

	496 margin-left: 45px;

	497 margin-top: 20px;

	498 }

	499

	500 .list-custom > li {

	501 margin-bottom: 25px;

	502 }

	503

	504 .list-custom .check-item,

	505 .list-custom .cross-item {

	506 min-height: 20px;

	507 padding-left: 45px;

	508 padding-top: 2px;

	509 }

	510

	511 .list-custom .check-item {

	512 background: url("/img/check.png") no-repeat 10px top;

	513 }

	514

	515 .list-custom .cross-item {

	516 background: url("/img/cross.png") no-repeat 10px top;

	517 }

OLD	NEW

« no previous file with comments | « pages/adware.md ('k') | static/img/check.png » ('j') | templates/default.tmpl » ('J')