Issue 3135 - Show the first run slide about the beta community to users that installed via Play and…

mobile/android/base/BrowserApp.java

 /* -*- Mode: Java; c-basic-offset: 4; tab-width: 4; indent-tabs-mode: nil; -*-
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 package org.mozilla.gecko;
 
 import org.mozilla.gecko.adjust.AdjustHelperInterface;
 import org.mozilla.gecko.annotation.RobocopTarget;
 import org.mozilla.gecko.AdjustConstants;
@@ skipping 3540 matching lines @@
 
         // Faster on main thread with an async apply().
         try {
             SharedPreferences settings = getPreferences(Activity.MODE_PRIVATE);
             int launchCount = settings.getInt(keyName, 0);
             // In Adblock Browser, we only want to increment the feedback page
             // launch count for release builds that were installed from the
             // Play store, see https://issues.adblockplus.org/ticket/2967 and
             // https://issues.adblockplus.org/ticket/3136.
             if (launchCount < FEEDBACK_LAUNCH_COUNT &&
-                AppConstants.ABB_RELEASE_BUILD && wasInstalledFromPlayStore()) {
+                AppConstants.ABB_RELEASE_BUILD && org.adblockplus.browser.BrowserAppUtils.wasInstalledFromPlayStore(this)) {

[anton, 2016/09/12 11:36:11]

what the point of using full classname with package? Can we use "import
org.adblockplus.browser.BrowserAppUtils;" and
"BrowserAppUtils.wasInstalledFromPlayStore(..)" here?

[diegocarloslima, 2016/10/20 12:18:07]

I agree with you that using an import + simple class name is better. I was
trying to keep up with the previous pattern that was being used in this file,
without adding any imports from our classes. I believe that this was done to
change the minimum amount of lines to this file, but I believe that it won't
hurt to add the imports to improve readability. I have created an issue #4555
which this one will depends on for next patch submitted

                 // Increment the launch count and store the new value.
                 launchCount++;
                 settings.edit().putInt(keyName, launchCount).apply();
 
                 // If we've reached our magic number, show the feedback page.
                 if (launchCount == FEEDBACK_LAUNCH_COUNT) {
                     GeckoAppShell.sendEventToGecko(GeckoEvent.createBroadcastEvent("Feedback:Show", null));
                 }
             }
         } finally {
             StrictMode.setThreadPolicy(savedPolicy);
         }
     }
 
-    private boolean wasInstalledFromPlayStore() {
-        final String installer = this.getPackageManager().getInstallerPackageName(this.getPackageName());
-        return "com.android.vending".equals(installer);
-    }
-
     private void showTabQueuePromptIfApplicable(final Intent intent) {
         ThreadUtils.postToBackgroundThread(new Runnable() {
             @Override
             public void run() {
                 // We only want to show the prompt if the browser has been opened from an external url
                 if (TabQueueHelper.TAB_QUEUE_ENABLED && mInitialized
                                                      && Intent.ACTION_VIEW.equals(intent.getAction())
                                                      && TabQueueHelper.shouldShowTabQueuePrompt(BrowserApp.this)) {
                     Intent promptIntent = new Intent(BrowserApp.this, TabQueuePrompt.class);
                     startActivityForResult(promptIntent, ACTIVITY_REQUEST_TAB_QUEUE);
@@ skipping 219 matching lines @@
         final boolean inGuestMode = GeckoProfile.get(this).inGuestMode();
         if (inGuestMode) {
             return StartupAction.GUEST;
         }
         if (RestrictedProfiles.isRestrictedProfile(this)) {
             return StartupAction.RESTRICTED;
         }
         return (passedURL == null ? StartupAction.NORMAL : StartupAction.URL);
     }
 }