Issue 2606 - Firefox logo shown in background on empty Adblock Browser New Tab and Search pages

mobile/android/base/home/PanelLayout.java

 /* -*- Mode: Java; c-basic-offset: 4; tab-width: 20; indent-tabs-mode: nil; -*-
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 package org.mozilla.gecko.home;
 
 import org.mozilla.gecko.R;
 import org.mozilla.gecko.db.BrowserContract.HomeItems;
 import org.mozilla.gecko.home.HomePager.OnUrlOpenListener;
@@ skipping 441 matching lines @@
             final TextView textView = (TextView) view.findViewById(R.id.home_empty_text);
             if (TextUtils.isEmpty(text)) {
                 textView.setText(R.string.home_default_empty);
             } else {
                 textView.setText(text);
             }
 
             final String imageUrl = (emptyViewConfig == null) ? null : emptyViewConfig.getImageUrl();
             final ImageView imageView = (ImageView) view.findViewById(R.id.home_empty_image);
 
+            // Changed icon. See https://issues.adblockplus.org/ticket/2606
             if (TextUtils.isEmpty(imageUrl)) {
-                // Changed icon. See https://issues.adblockplus.org/ticket/2606

[Felix Dahlke, 2016/11/17 18:38:51]

Nit: I guess it would suffice to have this comment once, above the block (i.e.
moving it one line up). But I don't mind either way, up to you AFAICT.

                 imageView.setImageResource(R.drawable.abb_icon_home_empty);
             } else {
-                // Changed icon. See https://issues.adblockplus.org/ticket/2606
                 ImageLoader.with(getContext())
                            .load(imageUrl)
                            .error(R.drawable.abb_icon_home_empty)
                            .into(imageView);
             }
 
             viewState.setEmptyView(view);
         }
 
         return view;
@@ skipping 263 matching lines @@
         public boolean canGoBack() {
             return mViewState.canPopFilter();
         }
 
         @Override
         public void goBack() {
             popFilterOnView(mViewState);
         }
     }
 }