Issue 4057 - Further speedup ElemHide.getSelectorsforDomain

test/elemHide.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 11 matching lines @@
   import: function()
   {
   }
 };
 
 let {ElemHide} = require("elemHide");
 let {Filter} = require("filterClasses");
 
 exports.testGetSelectorsForDomain = function(test)
 {
-  function fromText(f)
-  {
-    return (filterText) => f(Filter.fromText(filterText));
-  }
-  let addFilter = fromText(ElemHide.add);
-  let removeFilter = fromText(ElemHide.remove);
+  let addFilter = filterText => ElemHide.add(Filter.fromText(filterText));

[kzar, 2016/05/24 14:45:22]

`this` was being clobbered for the ElemHide methods.

+  let removeFilter = filterText => ElemHide.remove(Filter.fromText(filterText));
 
   function normalizeSelectors(selectors)
   {
     // getSelectorsForDomain is currently allowed to return duplicate selectors
     // for performance reasons, so we need to remove duplicates here.
     return selectors.sort().filter((selector, index, selectors) =>
     {
       return index == 0 || selector != selectors[index -  1];
     });
   }
@@ skipping 112 matching lines @@
 
   addFilter("~example.com##foo");
   selectorsEqual("foo.example.com", []);
   selectorsEqual("example.com", ["foo"]);
   selectorsEqual("com", ["foo"]);
   selectorsEqual("", ["foo"]);
   removeFilter("example.org##foo");
 
   test.done();
 };