Issue 2490 - Investigate another way to disable the crash reporter

configure.in

 dnl -*- Mode: Autoconf; tab-width: 4; indent-tabs-mode: nil; -*-
 dnl vi: set tabstop=4 shiftwidth=4 expandtab syntax=m4:
 dnl This Source Code Form is subject to the terms of the Mozilla Public
 dnl License, v. 2.0. If a copy of the MPL was not distributed with this
 dnl file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 dnl Process this file with autoconf to produce a configure script.
 dnl ========================================================
 
 AC_PREREQ(2.13)
@@ skipping 6022 matching lines @@
 
   AC_DEFINE(MOZ_GAMEPAD)
 fi
 AC_SUBST(MOZ_GAMEPAD)
 AC_SUBST(MOZ_GAMEPAD_BACKEND)
 
 dnl ========================================================
 dnl = Breakpad crash reporting (on by default on supported platforms)
 dnl ========================================================
 
-# case $target in

[anton, 2016/09/12 11:26:57]

should not we remove the lines instead of commenting out?

[diegocarloslima, 2016/09/14 23:31:24]

Yeah, you're right. I'll fix that.

-# i?86-*-mingw*|x86_64-*-mingw*)
-#   MOZ_CRASHREPORTER=1
-#   ;;
-# i?86-apple-darwin*|x86_64-apple-darwin*)
-#   if test -z "$MOZ_IOS"; then
-#     MOZ_CRASHREPORTER=1
-#   fi
-#   ;;
-# i?86-*-linux*|x86_64-*-linux*|arm-*-linux*)
-#   if test "$MOZ_ENABLE_GTK"; then
-#     MOZ_CRASHREPORTER=1
-#   fi
-#   ;;
-# *-android*|*-linuxandroid*)
-#   MOZ_CRASHREPORTER=1
-#   ;;
-# *solaris*)
-#   MOZ_CRASHREPORTER=1
-#   ;;
-# esac
-#
-# MOZ_ARG_DISABLE_BOOL(crashreporter,
-# [  --disable-crashreporter Disable breakpad crash reporting],
-#     [MOZ_CRASHREPORTER=],
-#     [MOZ_CRASHREPORTER=F # Force enable breakpad])
-#
-# if test "$OS_ARCH" != "$HOST_OS_ARCH" -a "$OS_ARCH" != "WINNT" -a "$OS_ARCH" != "Darwin"; then
-#   if test "$MOZ_CRASHREPORTER" = F; then
-#     AC_MSG_ERROR([Cannot --enable-crashreporter, as breakpad tools do not support compiling on $HOST_OS_ARCH while targeting $OS_ARCH.])
-#   fi
-#   MOZ_CRASHREPORTER=
-# fi
-#
+case $target in
+i?86-*-mingw*|x86_64-*-mingw*)
+  MOZ_CRASHREPORTER=1
+  ;;
+i?86-apple-darwin*|x86_64-apple-darwin*)
+  if test -z "$MOZ_IOS"; then
+    MOZ_CRASHREPORTER=1
+  fi
+  ;;
+i?86-*-linux*|x86_64-*-linux*|arm-*-linux*)
+  if test "$MOZ_ENABLE_GTK"; then
+    MOZ_CRASHREPORTER=1
+  fi
+  ;;
+*-android*|*-linuxandroid*)
+  MOZ_CRASHREPORTER=1
+  ;;
+*solaris*)
+  MOZ_CRASHREPORTER=1
+  ;;
+esac
+
+MOZ_ARG_DISABLE_BOOL(crashreporter,
+[  --disable-crashreporter Disable breakpad crash reporting],
+    [MOZ_CRASHREPORTER=],
+    [MOZ_CRASHREPORTER=F # Force enable breakpad])
+
+if test "$OS_ARCH" != "$HOST_OS_ARCH" -a "$OS_ARCH" != "WINNT" -a "$OS_ARCH" != "Darwin"; then
+  if test "$MOZ_CRASHREPORTER" = F; then
+    AC_MSG_ERROR([Cannot --enable-crashreporter, as breakpad tools do not support compiling on $HOST_OS_ARCH while targeting $OS_ARCH.])
+  fi
+  MOZ_CRASHREPORTER=
+fi
+
 # Force disable crashreporter
-# see https://issues.adblockplus.org/ticket/2490
+# See https://issues.adblockplus.org/ticket/2490
 MOZ_CRASHREPORTER=
 
 if test -n "$MOZ_CRASHREPORTER"; then
    AC_DEFINE(MOZ_CRASHREPORTER)
 
   if test "$OS_TARGET" = "Linux" -o "$OS_ARCH" = "SunOS" && \
     test -z "$SKIP_LIBRARY_CHECKS"; then
     PKG_CHECK_MODULES(MOZ_GTHREAD, gthread-2.0)
   fi
 
@@ skipping 3233 matching lines @@
 fi # COMPILE_ENVIRONMENT
 
 export WRITE_MOZINFO=1
 dnl we need to run config.status after js/src subconfigure because we're
 dnl traversing its moz.build and we need its config.status for that.
 dnl However, writing our own config.status needs to happen before
 dnl subconfigures because the setup surrounding subconfigures alters
 dnl many AC_SUBSTed variables.
 MOZ_RUN_CONFIG_STATUS()
 unset WRITE_MOZINFO