Issue 2490 - Investigate another way to disable the crash reporter

configure.in

Index: configure.in
===================================================================
--- a/configure.in
+++ b/configure.in
@@ -6035,49 +6035,53 @@ if test "$MOZ_GAMEPAD"; then
 fi
 AC_SUBST(MOZ_GAMEPAD)
 AC_SUBST(MOZ_GAMEPAD_BACKEND)
 
 dnl ========================================================
 dnl = Breakpad crash reporting (on by default on supported platforms)
 dnl ========================================================
 
-case $target in
-i?86-*-mingw*|x86_64-*-mingw*)
-  MOZ_CRASHREPORTER=1
-  ;;
-i?86-apple-darwin*|x86_64-apple-darwin*)
-  if test -z "$MOZ_IOS"; then
-    MOZ_CRASHREPORTER=1
-  fi
-  ;;
-i?86-*-linux*|x86_64-*-linux*|arm-*-linux*)
-  if test "$MOZ_ENABLE_GTK"; then
-    MOZ_CRASHREPORTER=1
-  fi
-  ;;
-*-android*|*-linuxandroid*)
-  MOZ_CRASHREPORTER=1
-  ;;
-*solaris*)
-  MOZ_CRASHREPORTER=1
-  ;;
-esac
-
-MOZ_ARG_DISABLE_BOOL(crashreporter,
-[  --disable-crashreporter Disable breakpad crash reporting],
-    [MOZ_CRASHREPORTER=],
-    [MOZ_CRASHREPORTER=F # Force enable breakpad])
-
-if test "$OS_ARCH" != "$HOST_OS_ARCH" -a "$OS_ARCH" != "WINNT" -a "$OS_ARCH" != "Darwin"; then
-  if test "$MOZ_CRASHREPORTER" = F; then
-    AC_MSG_ERROR([Cannot --enable-crashreporter, as breakpad tools do not support compiling on $HOST_OS_ARCH while targeting $OS_ARCH.])
-  fi
-  MOZ_CRASHREPORTER=
-fi
+# case $target in

[anton, 2016/09/12 11:26:57]

should not we remove the lines instead of commenting out?

[diegocarloslima, 2016/09/14 23:31:24]

Yeah, you're right. I'll fix that.

+# i?86-*-mingw*|x86_64-*-mingw*)
+#   MOZ_CRASHREPORTER=1
+#   ;;
+# i?86-apple-darwin*|x86_64-apple-darwin*)
+#   if test -z "$MOZ_IOS"; then
+#     MOZ_CRASHREPORTER=1
+#   fi
+#   ;;
+# i?86-*-linux*|x86_64-*-linux*|arm-*-linux*)
+#   if test "$MOZ_ENABLE_GTK"; then
+#     MOZ_CRASHREPORTER=1
+#   fi
+#   ;;
+# *-android*|*-linuxandroid*)
+#   MOZ_CRASHREPORTER=1
+#   ;;
+# *solaris*)
+#   MOZ_CRASHREPORTER=1
+#   ;;
+# esac
+#
+# MOZ_ARG_DISABLE_BOOL(crashreporter,
+# [  --disable-crashreporter Disable breakpad crash reporting],
+#     [MOZ_CRASHREPORTER=],
+#     [MOZ_CRASHREPORTER=F # Force enable breakpad])
+#
+# if test "$OS_ARCH" != "$HOST_OS_ARCH" -a "$OS_ARCH" != "WINNT" -a "$OS_ARCH" != "Darwin"; then
+#   if test "$MOZ_CRASHREPORTER" = F; then
+#     AC_MSG_ERROR([Cannot --enable-crashreporter, as breakpad tools do not support compiling on $HOST_OS_ARCH while targeting $OS_ARCH.])
+#   fi
+#   MOZ_CRASHREPORTER=
+# fi
+#
+# Force disable crashreporter
+# see https://issues.adblockplus.org/ticket/2490
+MOZ_CRASHREPORTER=
 
 if test -n "$MOZ_CRASHREPORTER"; then
    AC_DEFINE(MOZ_CRASHREPORTER)
 
   if test "$OS_TARGET" = "Linux" -o "$OS_ARCH" = "SunOS" && \
     test -z "$SKIP_LIBRARY_CHECKS"; then
     PKG_CHECK_MODULES(MOZ_GTHREAD, gthread-2.0)
   fi