Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: tests/test_packagerEdge.py

Issue 29345751: Issue 4028 - Add support for Edge extensions to buildtools (Closed)
Patch Set: Address comments on patch set 1 Created June 17, 2016, 5:51 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/test_packagerEdge.py
===================================================================
new file mode 100644
--- /dev/null
+++ b/tests/test_packagerEdge.py
@@ -0,0 +1,130 @@
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+import ConfigParser
+import io
+import os
+import shutil
+import sys
+import xml.etree.ElementTree as ET
+import zipfile
+
+import pytest
+
+TEST_DIR = os.path.dirname(__file__)
+
+sys.path.insert(0, os.path.dirname(os.path.dirname(TEST_DIR)))
+
+from buildtools import packager, packagerEdge # noqa: must modify path before this.
Sebastian Noack 2016/07/01 15:56:04 Perhaps it's better to just set the PYTHONPATH in
Vasily Kuznetsov 2016/07/01 19:51:28 You're right. Much less ugly. Done.
+
+TEST_METADATA = os.path.join(TEST_DIR, 'metadata.edge')
+CHARS = b''.join(chr(i % 200 + 30) for i in range(500))
+
+
+@pytest.fixture
+def metadata():
+ """Loaded metadata config."""
+ conf_parser = ConfigParser.ConfigParser()
+ conf_parser.read(TEST_METADATA)
+ return conf_parser
+
+
+@pytest.fixture
+def srcdir(tmpdir):
+ """Source directory for building the package."""
+ srcdir = tmpdir.mkdir('src')
+ shutil.copy(TEST_METADATA, str(srcdir.join('metadata.edge')))
+ for size in ['44', '50', '150']:
+ path = srcdir.join('chrome', 'icons', 'abp-{}.png'.format(size))
+ path.write(size, ensure=True)
+ return srcdir
+
+
+def blockmap2dict(xml_data):
+ """Convert AppxBlockMap.xml to a dict of dicts easier to inspect."""
+ return {
+ file.get('Name'): {
+ 'size': file.get('Size'),
+ 'lfhsize': file.get('LfhSize'),
+ 'blocks': [
+ {'hash': b.get('Hash'), 'size': b.get('Size', None)}
+ for b in file
+ ]
+ }
+ for file in ET.fromstring(xml_data)
+ }
+
+
+def test_create_appx_blockmap():
+ files = packager.Files(set(), set())
+ files['foo.xml'] = CHARS
+ files['foo/bar.png'] = CHARS * 200
+ blockmap = blockmap2dict(packagerEdge.createAppxBlockmap(files))
+ assert blockmap['foo.xml'] == {
+ 'size': '500',
+ 'lfhsize': '37',
+ 'blocks': [
+ {'hash': 'Vhwfmzss1Ney+j/ssR2QVISvFyMNBQeS2P+UjeE/di0=',
+ 'size': '500'}
+ ]
+ }
+ assert blockmap['foo\\bar.png'] == {
+ 'size': '100000',
+ 'lfhsize': '41',
+ 'blocks': [
+ {'hash': 'KPW2SxeEikUEGhoKmKxruUSexKun0bGXMppOqUFrX5E=',
+ 'size': '65536'},
+ {'hash': 'KQHnov1SZ1z34ttdDUjX2leYtpIIGndUVoUteieS2cw=',
+ 'size': '34464'}
+ ]
+ }
+
+
+def test_create_appx_manifest(metadata):
+ files = packager.Files(set(), set())
+ for size in ['44', '50', '150']:
+ files['Assets/logo_{}.png'.format(size)] = CHARS
+ manifest = packagerEdge.createAppxManifest({'metadata': metadata}, files)
+ with open(os.path.join(TEST_DIR, 'AppManifest.xml.expect')) as fp:
+ manifest_expect = fp.read()
+ assert manifest.strip() == manifest_expect.strip()
+
+
+def test_move_files_to_extension():
+ files = packager.Files(set(), set())
+ files['foo.xml'] = CHARS
+ files['foo/bar.xml'] = CHARS
+ files['Extension/foo.xml'] = CHARS
+ packagerEdge.moveFilesToExtension(files)
+ assert set(files.keys()) == {
+ 'Extension/foo.xml',
+ 'Extension/foo/bar.xml',
+ 'Extension/Extension/foo.xml'
+ }
+
+
+def test_edge_files_zip():
+ """Test zip conversion of EdgeFiles that is overriden."""
+ files = packagerEdge.Files(set(), set())
+ files['Foo.xml'] = CHARS
+ files['bar.xml'] = CHARS
+ buffer = io.BytesIO()
+ files.zip(buffer, sortKey=lambda name: name.lower())
+ result = zipfile.ZipFile(buffer)
+ assert result.getinfo('Foo.xml').compress_type == zipfile.ZIP_STORED
+ assert result.namelist() == ['bar.xml', 'Foo.xml', 'AppxBlockMap.xml']
+
+
+def test_create_build(tmpdir, srcdir):
+ out_file = str(tmpdir.join('abp.appx'))
+ packagerEdge.createBuild(str(srcdir), outFile=out_file)
+ appx = zipfile.ZipFile(out_file)
+
+ names = set(appx.namelist())
+ assert 'AppxManifest.xml' in names
+ assert 'AppxBlockMap.xml' in names
+ assert '[Content_Types].xml' in names
+
+ assert appx.read('Assets/logo_44.png') == '44'
+ assert appx.read('Extension/icons/abp-44.png') == '44'

Powered by Google App Engine
This is Rietveld