Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java

Issue 29346561: Issue 4160 - Return headers in AndroidWebRequest (Closed)
Patch Set: Codestyle fixes #2 Created July 19, 2016, 9:49 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 sb.append((char) character); 125 sb.append((char) character);
126 } 126 }
127 } 127 }
128 128
129 response.setStatus(NsStatus.OK); 129 response.setStatus(NsStatus.OK);
130 response.setResponse(sb.toString()); 130 response.setResponse(sb.toString());
131 131
132 if (connection.getHeaderFields().size() > 0) 132 if (connection.getHeaderFields().size() > 0)
133 { 133 {
134 List<HeaderEntry> responseHeaders = new LinkedList<HeaderEntry>(); 134 List<HeaderEntry> responseHeaders = new LinkedList<HeaderEntry>();
135 for (Map.Entry<String, List<String>> eachEntry : 135 for (Map.Entry<String, List<String>> eachEntry : connection.getHeade rFields().entrySet())
anton 2016/07/19 09:50:30 decided to fit it into 1 line (though it's 101 cha
diegocarloslima 2016/09/06 23:02:14 This 'for' block still have wrong indentation. It
anton 2016/09/08 13:27:44 Acknowledged.
136 connection.getHeaderFields().entrySet())
137 { 136 {
138 for (String eachValue : eachEntry.getValue()) 137 for (String eachValue : eachEntry.getValue())
139 { 138 {
140 if (eachEntry.getKey() != null && eachValue != null) 139 if (eachEntry.getKey() != null && eachValue != null)
140 {
141 responseHeaders.add(new HeaderEntry(eachEntry.getKey(), eachVa lue)); 141 responseHeaders.add(new HeaderEntry(eachEntry.getKey(), eachVa lue));
142 }
142 } 143 }
143 } 144 }
144 response.setReponseHeaders(responseHeaders); 145 response.setReponseHeaders(responseHeaders);
145 } 146 }
146 147
147 connection.disconnect(); 148 connection.disconnect();
148 } 149 }
149 else 150 else
150 { 151 {
151 response.setStatus(NsStatus.ERROR_FAILURE); 152 response.setStatus(NsStatus.ERROR_FAILURE);
152 } 153 }
153 return response; 154 return response;
154 } 155 }
155 catch (final Throwable t) 156 catch (final Throwable t)
156 { 157 {
157 throw new AdblockPlusException("WebRequest failed", t); 158 throw new AdblockPlusException("WebRequest failed", t);
158 } 159 }
159 } 160 }
160 } 161 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld