Issue 4181 - Fix FilterEngineTest tests

libadblockplus-android-tests/src/org/adblockplus/libadblockplus/FileSystemUtils.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 32 matching lines @@
       sb.append(suffix);
     }
     return sb.toString();
   }
 
   public static File generateUniqueFile(String prefix, String suffix, File parent)
   {
     return new File(parent, generateUniqueFileName(prefix, suffix));
   }
 
-  public void delete(String filePath, boolean deleteSelf)

[diegocarloslima, 2016/11/03 14:06:02]

This method is missing the static modifier

[anton, 2016/12/02 06:15:03]

Acknowledged.

+  public static void delete(String filePath, boolean deleteSelf)

[Felix Dahlke, 2017/05/09 08:06:45]

I may have missed something, but it appears `deleteSelf` is never set to
anything but `true`. So maybe we should just assume that behaviour here? I'm not
a fan of having unused code paths.

[anton, 2017/05/10 11:00:14]

Done.

   {
     delete(new File(filePath), deleteSelf);
   }
 
   public static void delete(File file, boolean deleteSelf)
   {
     if (file.isDirectory())
     {
       deleteDirectory(file, deleteSelf);
     }
@@ skipping 17 matching lines @@
       directory.delete();
     }
   }
 
   public static void deleteFile(File file)
   {
     Log.w(TAG, "Deleting file " + file.getAbsolutePath());
     file.delete();
   }
 }