Issue 4231 - Fix unstable FilterEngineTest.testSetRemoveFilterChangeCallback

libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 package org.adblockplus.libadblockplus.tests;
 
 import org.adblockplus.libadblockplus.Filter;
 import org.adblockplus.libadblockplus.FilterEngine;
+import org.adblockplus.libadblockplus.LazyWebRequest;
 import org.adblockplus.libadblockplus.MockFilterChangeCallback;
 import org.adblockplus.libadblockplus.Subscription;
 
 import org.junit.Test;
 
 public class FilterEngineTest extends FilterEngineGenericTest
 {
     @Test
     public void testFilterCreation()
     {
@@ skipping 281 matching lines @@
                 "http://example.org/",
                 "http://example.com/"
             });
         assertNotNull(match5);
         assertEquals(Filter.Type.EXCEPTION, match5.getType());
     }
 
     @Test
     public void testFirstRunFlag()
     {
-        assertFalse(filterEngine.isFirstRun());
+        jsEngine.setWebRequest(new LazyWebRequest());
+        jsEngine.setDefaultLogSystem();
+
+        LazyFileSystem lazyFileSystem = new LazyFileSystem();
+        lazyFileSystem.setPatternsIniExists(false);
+        jsEngine.setFileSystem(lazyFileSystem);
+
+        filterEngine = new FilterEngine(jsEngine);
+        assertTrue(filterEngine.isFirstRun());
     }
 
     @Test
     public void testSetRemoveFilterChangeCallback()
     {
         MockFilterChangeCallback mockFilterChangeCallback = new MockFilterChangeCallback(0);
 
         filterEngine.setFilterChangeCallback(mockFilterChangeCallback);
         filterEngine.getFilter("foo").addToList();
         assertEquals(1, mockFilterChangeCallback.getTimesCalled());
@@ skipping 40 matching lines @@
         assertFalse(filterEngine.isElemhideWhitelisted("http://example.com", emptyArray));
 
         String[] documentUrls1 = new String[]
         {
             "http://example.de"
         };
         assertTrue(filterEngine.isElemhideWhitelisted("http://example.com", documentUrls1));
         assertFalse(filterEngine.isElemhideWhitelisted("http://example.co.uk", documentUrls1));
     }
 }