Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Side by Side Diff: third_party/checkstyle/java/rules/mozilla_checks.xml

Issue 29347926: Issue 4248 - Add codestyle check
Patch Set: changed import order - `org.adblockplus` package first Created Dec. 2, 2016, 6:19 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« third_party/checkstyle/java/rules/google_checks.xml ('K') | « third_party/checkstyle/java/rules/google_checks.xml ('k') | third_party/checkstyle/java/rules/sun_checks.xml » ('j') | third_party/checkstyle/java/rules/sun_checks.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 <?xml version="1.0"?>
2 <!DOCTYPE module PUBLIC
3 "-//Puppy Crawl//DTD Check Configuration 1.2//EN"
4 "http://www.puppycrawl.com/dtds/configuration_1_2.dtd">
5
6 <!--
7
8 https://github.com/mozilla-services/mozilla-style/blob/master/java/checkstyle.xm l
9
10 This file contains a Checkstyle configuration that checks for compliance with
11 Mozilla's Java style conventions.
12
13 The file defines the modules and properties in alpabetical order. Each property
14 should be documented with what it does.
15 -->
16
17 <module name="Checker">
18 <module name="TreeWalker">
19
20 <!-- Annotations. http://checkstyle.sourceforge.net/config_annotation.html - ->
21 <module name="AnnotationUseStyle"/>
22 <module name="MissingDeprecated"/>
23 <module name="MissingOverride"/>
24 <module name="SuppressWarnings"/>
25
26 <!-- Block checks. See http://checkstyle.sourceforge.net/config_blocks.html -->
27 <module name="AvoidNestedBlocks"/>
28 <module name="EmptyBlock"/>
29 <module name="LeftCurly"/>
30 <module name="NeedBraces"/>
31 <module name="RightCurly"/>
32
33 <!-- Class Design. http://checkstyle.sourceforge.net/config_design.html -->
34 <module name="DesignForExtension"/>
35 <module name="FinalClass"/>
36 <module name="HideUtilityClassConstructor"/>
37 <module name="InterfaceIsType"/>
38 <module name="InnerTypeLast"/>
39 <module name="MutableException"/>
40 <module name="VisibilityModifier"/>
41
42 <!-- Common coding problems. See http://checkstyle.sf.net/config_coding.html -->
43 <module name="ArrayTrailingComma"/>
44 <module name="CovariantEquals"/>
45 <module name="DeclarationOrder"/>
46 <module name="DefaultComesLast"/>
47 <module name="EmptyStatement"/>
48 <module name="EqualsHashCode"/>
49 <module name="EqualsAvoidNull"/>
50 <module name="ExplicitInitialization"/>
51 <module name="HiddenField"/>
52 <module name="IllegalCatch"/>
53 <module name="IllegalInstantiation"/>
54 <module name="IllegalThrows"/>
55 <module name="IllegalToken"/>
56 <module name="IllegalType"/>
57 <module name="InnerAssignment"/>
58 <module name="MagicNumber"/>
59 <module name="MissingCtor"/>
60 <module name="MissingSwitchDefault"/>
61 <module name="ModifiedControlVariable"/>
62 <module name="MultipleStringLiterals"/>
63 <module name="MultipleVariableDeclarations"/>
64 <module name="NestedForDepth"/>
65 <module name="NoClone"/>
66 <module name="NoFinalizer"/>
67 <module name="OneStatementPerLine"/>
68 <module name="PackageDeclaration"/>
69 <module name="ParameterAssignment"/>
70 <module name="SimplifyBooleanExpression"/>
71 <module name="SimplifyBooleanReturn"/>
72 <module name="StringLiteralEquality"/>
73 <module name="UnnecessaryParentheses"/>
74
75 <!-- Duplicate code. http://checkstyle.sourceforge.net/config_duplicates.htm l -->
76
77 <!-- Header. See http://checkstyle.sourceforge.net/config_header.html -->
78 <!-- TODO detect MPL 2.0 in all files. -->
79
80 <!-- Imports. See http://checkstyle.sf.net/config_import.html -->
81 <module name="AvoidStarImport"/>
82 <module name="IllegalImport"/>
83 <module name="ImportOrder">
84 <!-- Android's import guidelines: http://source.android.com/source/code-st yle.html#order-import-statements -->
85 <property name="groups" value="android,ch,com,net,org,java,javax"/>
86 <property name="separated" value="true"/>
87 </module>
88 <module name="AvoidStaticImport"/>
89 <module name="RedundantImport"/>
90 <module name="UnusedImports"/>
91
92 <!-- Javadoc. See http://checkstyle.sourceforge.net/config_javadoc.html -->
93 <module name="JavadocMethod"/>
94 <module name="JavadocStyle"/>
95 <module name="JavadocType"/>
96 <module name="JavadocVariable"/>
97
98 <!-- Metrics. See http://checkstyle.sourceforge.net/config_metrics.html -->
99
100 <!-- Miscellaneous. See http://checkstyle.sourceforge.net/config_misc.html - ->
101 <module name="ArrayTypeStyle"/>
102 <module name="Indentation"/>
103 <module name="OuterTypeFilename"/>
104 <module name="TodoComment">
105 <property name="format" value="FIX ?ME|TO-?DO|XXX"/>
106 </module>
107 <module name="UpperEll"/>
108
109 <!-- Modifiers. See http://checkstyle.sourceforge.net/config_modifier.html - ->
110 <module name="ModifierOrder"/>
111 <module name="RedundantModifier"/>
112
113 <!-- Naming Conventions. See http://checkstyle.sourceforge.net/config_naming .html -->
114 <module name="ConstantName"/>
115 <module name="LocalFinalVariableName"/>
116 <module name="LocalVariableName"/>
117 <module name="MemberName">
118 <!-- We require member names to be prefixed with 'm'. -->
119 <property name="format" value="^m[A-Z][a-zA-Z0-9]*$" />
120 </module>
121 <module name="MethodName"/>
122 <module name="PackageName"/>
123 <module name="ParameterName"/>
124 <module name="StaticVariableName">
125 <!-- We require static member names to be prefixed with 's'. -->
126 <property name="format" value="^s[A-Z][a-zA-Z0-9]*$" />
127 </module>
128 <module name="TypeName"/>
129
130 <!-- Regular expressions. See http://checkstyle.sourceforge.net/config_regex p.html -->
131
132 <!-- Size violations. See http://checkstyle.sourceforge.net/config_sizes.htm l -->
133 <module name="AnonInnerLength"/>
134 <module name="LineLength">
135 <property name="max" value="100" />
136 </module>
137 <module name="MethodCount"/>
138 <module name="MethodLength"/>
139 <module name="OuterTypeNumber"/>
140 <module name="ParameterNumber"/>
141
142 <!-- Whitespace. See http://checkstyle.sourceforge.net/config_whitespace.htm l -->
143 <module name="EmptyForInitializerPad"/>
144 <module name="EmptyForIteratorPad"/>
145 <module name="GenericWhitespace"/>
146 <module name="MethodParamPad"/>
147 <module name="NoWhitespaceAfter"/>
148 <module name="NoWhitespaceBefore"/>
149 <module name="OperatorWrap"/>
150 <module name="ParenPad"/>
151 <module name="TypecastParenPad"/>
152 <module name="WhitespaceAfter"/>
153 <module name="WhitespaceAround"/>
154
155 </module>
156
157 <module name="FileLength"/>
158
159 <module name="FileTabCharacter">
160 <property name="eachLine" value="true"/>
161 </module>
162
163 <module name="NewlineAtEndOfFile"/>
164
165 <module name="RegexpSingleline">
166 <!-- Check for trailing whitespace. -->
167 <property name="format" value="\s+$"/>
168 <property name="message" value="Line has trailing spaces."/>
169 </module>
170
171 </module>
OLDNEW
« third_party/checkstyle/java/rules/google_checks.xml ('K') | « third_party/checkstyle/java/rules/google_checks.xml ('k') | third_party/checkstyle/java/rules/sun_checks.xml » ('j') | third_party/checkstyle/java/rules/sun_checks.xml » ('J')

Powered by Google App Engine
This is Rietveld