libadblockplus-android/build.gradle - Issue 29347926: Issue 4248 - Add codestyle check

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: libadblockplus-android/build.gradle

Issue 29347926: Issue 4248 - Add codestyle check

Left Patch Set: added Gradle support, removed Ant support, added original files URLs Created April 14, 2017, 11:56 a.m.

Right Patch Set: moved 'third_party' to review https://codereview.adblockplus.org/29567648/ Created Oct. 6, 2017, 11:33 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 apply plugin: 'com.android.library'	1 apply plugin: 'com.android.library'

2 apply plugin: 'checkstyle'	2 apply plugin: 'checkstyle'

3	3

4 android {	4 android {

5 compileSdkVersion 16	5 compileSdkVersion 16

6 buildToolsVersion "25.0.0"	6 buildToolsVersion "25.0.0"

7	7

8 defaultConfig {	8 defaultConfig {

9 minSdkVersion 11	9 minSdkVersion 11

10 targetSdkVersion 16	10 targetSdkVersion 16

(...skipping 29 matching lines...) Expand all Loading...
40 ignoreFailures = true	40 ignoreFailures = true

41 showViolations = true	41 showViolations = true

42 source 'src/org/adblockplus/'	42 source 'src/org/adblockplus/'

43 exclude '/gen/'	43 exclude '/gen/'

44 exclude '**/R.java'	44 exclude '**/R.java'

45 exclude '**/BuildConfig.java'	45 exclude '**/BuildConfig.java'

46 reports {	46 reports {

47 xml.destination "$project.buildDir/reports/checkstyle/main.xml"	47 xml.destination "$project.buildDir/reports/checkstyle/main.xml"

48 }	48 }

49 classpath = files()	49 classpath = files()

50 configFile = file("${rootProject.rootDir}/third_party/checkstyle/java/rules/ eyeo_checks.xml")	50 configFile = file("${rootProject.rootDir}/third_party/checkstyle/java/rules/ eyeo_production_checks.xml")

51 configProperties = [	51 configProperties = [

52 "checkstyle.header.file" : file("${rootProject.rootDir}/third_party/chec kstyle/java/res/header.txt")	52 "checkstyle.header.file" : file("${rootProject.rootDir}/third_party/chec kstyle/java/res/header.txt")

53 ]	53 ]

54 }	54 }

LEFT	RIGHT