Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: mobile/android/base/resources/values/themes.xml

Issue 29348083: Issue 3769 - UI colours gone bad (Closed)
Patch Set: Created July 21, 2016, 2:09 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- This Source Code Form is subject to the terms of the Mozilla Public 2 <!-- This Source Code Form is subject to the terms of the Mozilla Public
3 - License, v. 2.0. If a copy of the MPL was not distributed with this 3 - License, v. 2.0. If a copy of the MPL was not distributed with this
4 - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> 4 - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
5 5
6 <resources> 6 <resources>
7 7
8 <!-- Using ABB color palette in some styles. See https://issues.adblockplus. org/ticket/3769 -->
9
8 <!-- 10 <!--
9 Base application theme. This could be overridden by GeckoBaseTheme 11 Base application theme. This could be overridden by GeckoBaseTheme
10 in other res/values-XXX/themes.xml. 12 in other res/values-XXX/themes.xml.
11 13
12 Bug 1215079: we inherit from android:* on GB but AppCompat in later vers ions. 14 Bug 1215079: we inherit from android:* on GB but AppCompat in later vers ions.
13 Inheriting only from the AppCompat style but not extending AppCompat cau ses the 15 Inheriting only from the AppCompat style but not extending AppCompat cau ses the
14 menu to be transparent and we can't correctly override the color on all devices 16 menu to be transparent and we can't correctly override the color on all devices
15 while also extending AppCompat disables the menu entirely due to a frame work bug. 17 while also extending AppCompat disables the menu entirely due to a frame work bug.
16 We're stuck until we always show the overflow menu (bug 1209967). 18 We're stuck until we always show the overflow menu (bug 1209967).
17 --> 19 -->
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 <!-- Make an activity appear like an overlay. --> 117 <!-- Make an activity appear like an overlay. -->
116 <style name="OverlayActivity" parent="Gecko"> 118 <style name="OverlayActivity" parent="Gecko">
117 <item name="android:windowBackground">@android:color/transparent</item> 119 <item name="android:windowBackground">@android:color/transparent</item>
118 <item name="android:windowNoTitle">true</item> 120 <item name="android:windowNoTitle">true</item>
119 <item name="android:windowIsTranslucent">true</item> 121 <item name="android:windowIsTranslucent">true</item>
120 <item name="android:backgroundDimEnabled">true</item> 122 <item name="android:backgroundDimEnabled">true</item>
121 123
122 <!-- Set the app's title bar color in the recent app switcher. 124 <!-- Set the app's title bar color in the recent app switcher.
123 125
124 Note: We'd prefer not to show up in the recent app switcher (bug 11 37928). --> 126 Note: We'd prefer not to show up in the recent app switcher (bug 11 37928). -->
125 <item name="android:colorPrimary">@color/text_and_tabs_tray_grey</item> 127 <item name="android:colorPrimary">@color/abb_background_light_grey</item >
126 <!-- We display the overlay on top of other Activities so show their sta tus bar. --> 128 <!-- We display the overlay on top of other Activities so show their sta tus bar. -->
127 <item name="android:statusBarColor">@android:color/transparent</item> 129 <item name="android:statusBarColor">@android:color/transparent</item>
128 </style> 130 </style>
129 131
130 </resources> 132 </resources>
OLDNEW

Powered by Google App Engine
This is Rietveld