Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: mobile/android/base/resources/values/dimens.xml

Issue 29348083: Issue 3769 - UI colours gone bad (Closed)
Patch Set: Adjusting comments which indicates what has being changed by this issue in upstream code Created Oct. 25, 2016, 12:16 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- This Source Code Form is subject to the terms of the Mozilla Public 2 <!-- This Source Code Form is subject to the terms of the Mozilla Public
3 - License, v. 2.0. If a copy of the MPL was not distributed with this 3 - License, v. 2.0. If a copy of the MPL was not distributed with this
4 - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> 4 - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
5 5
6 <resources> 6 <resources>
7 7
8 <dimen name="standard_corner_radius">4dp</dimen> 8 <dimen name="standard_corner_radius">4dp</dimen>
9 9
10 <dimen name="autocomplete_min_width">200dp</dimen> 10 <dimen name="autocomplete_min_width">200dp</dimen>
11 <dimen name="autocomplete_row_height">32dp</dimen> 11 <dimen name="autocomplete_row_height">32dp</dimen>
12 12
13 <dimen name="browser_toolbar_height">48dp</dimen> 13 <dimen name="browser_toolbar_height">48dp</dimen>
14 <!-- This value is the height of the Tabs Panel header view 14 <!-- This value is the height of the Tabs Panel header view
15 (browser_toolbar_height) minus the height of the indicator 15 (browser_toolbar_height) minus the height of the indicator
16 (6dp). This value should change when the height of the view changes. -- > 16 (6dp). This value should change when the height of the view changes. -- >
17 <dimen name="tabs_panel_indicator_selected_padding_top">42dp</dimen> 17 <dimen name="tabs_panel_indicator_selected_padding_top">42dp</dimen>
18 18
19 <!-- We use two different values for browser_toolbar_height on tablet 19 <!-- We use two different values for browser_toolbar_height on tablet
20 which is inconsistent. Temporary value until bug 1150730 is fixed. --> 20 which is inconsistent. Temporary value until bug 1150730 is fixed. -->
21 <dimen name="browser_toolbar_height_flipper">48dp</dimen> 21 <dimen name="browser_toolbar_height_flipper">48dp</dimen>
22 <dimen name="browser_toolbar_button_padding">12dp</dimen> 22 <dimen name="browser_toolbar_button_padding">12dp</dimen>
23 <dimen name="browser_toolbar_icon_width">48dp</dimen> 23 <dimen name="browser_toolbar_icon_width">48dp</dimen>
24 <dimen name="browser_toolbar_menu_icon_height">16dp</dimen> 24 <dimen name="browser_toolbar_menu_icon_height">16dp</dimen>
25 25
26 <!-- favicon_size includes 4dp of right padding. We can't use margin (which would allow us to 26 <!-- favicon_size includes 4dp of right padding. We can't use margin (which would allow us to
27 specify the actual size) because that would decrease the size of our hi t target. --> 27 specify the actual size) because that would decrease the size of our hi t target. -->
28 <dimen name="browser_toolbar_favicon_size">21.33dip</dimen> 28 <dimen name="browser_toolbar_favicon_size">21.33dip</dimen>
29 <dimen name="browser_toolbar_shadow_size">2dp</dimen> 29 <!-- Using ABB dimension from style guide. See https://issues.adblockplus.or g/ticket/3769 -->
30 <dimen name="browser_toolbar_shadow_size">@dimen/abb_browser_toolbar_divider </dimen>
30 31
31 <!-- If you update one of these values, update the others. --> 32 <!-- If you update one of these values, update the others. -->
32 <dimen name="tablet_nav_button_width">42dp</dimen> 33 <dimen name="tablet_nav_button_width">42dp</dimen>
33 <dimen name="tablet_nav_button_width_half">21dp</dimen> 34 <dimen name="tablet_nav_button_width_half">21dp</dimen>
34 <dimen name="tablet_nav_button_width_plus_half">63dp</dimen> 35 <dimen name="tablet_nav_button_width_plus_half">63dp</dimen>
35 36
36 <!-- This is the system default for the vertical padding for the divider of the TabWidget. 37 <!-- This is the system default for the vertical padding for the divider of the TabWidget.
37 Used to mimic the divider padding on the tablet tabs panel back button. --> 38 Used to mimic the divider padding on the tablet tabs panel back button. -->
38 <dimen name="tab_panel_divider_vertical_padding">12dp</dimen> 39 <dimen name="tab_panel_divider_vertical_padding">12dp</dimen>
39 40
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 218
218 <!-- http://blog.danlew.net/2015/01/06/handling-android-resources-with-non-s tandard-formats/ --> 219 <!-- http://blog.danlew.net/2015/01/06/handling-android-resources-with-non-s tandard-formats/ -->
219 <item name="match_parent" type="dimen">-1</item> 220 <item name="match_parent" type="dimen">-1</item>
220 <item name="wrap_content" type="dimen">-2</item> 221 <item name="wrap_content" type="dimen">-2</item>
221 222
222 <item name="tab_strip_content_start" type="dimen">12dp</item> 223 <item name="tab_strip_content_start" type="dimen">12dp</item>
223 224
224 <item name="split_plane_left_pane_weight" format="float" type="dimen">0.32</ item> 225 <item name="split_plane_left_pane_weight" format="float" type="dimen">0.32</ item>
225 <item name="split_plane_right_pane_weight" format="float" type="dimen">0.68< /item> 226 <item name="split_plane_right_pane_weight" format="float" type="dimen">0.68< /item>
226 </resources> 227 </resources>
OLDNEW
« no previous file with comments | « mobile/android/base/resources/values/colors.xml ('k') | mobile/android/base/resources/values/styles.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld