Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: mobile/android/base/resources/drawable/tab_thumbnail.xml

Issue 29348083: Issue 3769 - UI colours gone bad (Closed)
Left Patch Set: Created July 21, 2016, 2:09 a.m.
Right Patch Set: Adjusting comments which indicates what has being changed by this issue in upstream code Created Oct. 25, 2016, 12:16 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- This Source Code Form is subject to the terms of the Mozilla Public 2 <!-- This Source Code Form is subject to the terms of the Mozilla Public
3 - License, v. 2.0. If a copy of the MPL was not distributed with this 3 - License, v. 2.0. If a copy of the MPL was not distributed with this
4 - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> 4 - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
5 5
6 <selector xmlns:android="http://schemas.android.com/apk/res/android" 6 <selector xmlns:android="http://schemas.android.com/apk/res/android"
7 xmlns:gecko="http://schemas.android.com/apk/res-auto"> 7 xmlns:gecko="http://schemas.android.com/apk/res-auto">
8 8
9 <!-- Using ABB color palette. See https://issues.adblockplus.org/ticket/3769 -->
10 <item android:state_focused="true"> 9 <item android:state_focused="true">
11 10
12 <shape android:shape="rectangle"> 11 <shape android:shape="rectangle">
12 <!-- Using ABB color palette. See https://issues.adblockplus.org/tic ket/3769 -->
13 <solid android:color="@color/abb_accent_dark_blue_alpha"/> 13 <solid android:color="@color/abb_accent_dark_blue_alpha"/>
14 <corners android:radius="1dp"/> 14 <corners android:radius="1dp"/>
15 </shape> 15 </shape>
16 16
17 </item> 17 </item>
18 18
19 <item android:state_focused="true" 19 <item android:state_focused="true"
20 gecko:state_private="true"> 20 gecko:state_private="true">
21 21
22 <shape android:shape="rectangle"> 22 <shape android:shape="rectangle">
23 <!-- Using ABB color palette. See https://issues.adblockplus.org/tic ket/3769 -->
23 <solid android:color="@color/abb_private_purple_alpha"/> 24 <solid android:color="@color/abb_private_purple_alpha"/>
24 <corners android:radius="1dp"/> 25 <corners android:radius="1dp"/>
25 </shape> 26 </shape>
26 27
27 </item> 28 </item>
28 29
29 <item android:state_pressed="true" 30 <item android:state_pressed="true"
30 gecko:state_private="true"> 31 gecko:state_private="true">
31 32
32 <shape android:shape="rectangle"> 33 <shape android:shape="rectangle">
34 <!-- Using ABB color palette. See https://issues.adblockplus.org/tic ket/3769 -->
33 <solid android:color="@color/abb_private_purple_alpha"/> 35 <solid android:color="@color/abb_private_purple_alpha"/>
34 <corners android:radius="1dp"/> 36 <corners android:radius="1dp"/>
35 </shape> 37 </shape>
36 38
37 </item> 39 </item>
38 40
39 <item android:state_pressed="true"> 41 <item android:state_pressed="true">
40 42
41 <shape android:shape="rectangle"> 43 <shape android:shape="rectangle">
44 <!-- Using ABB color palette. See https://issues.adblockplus.org/tic ket/3769 -->
42 <solid android:color="@color/abb_accent_dark_blue_alpha"/> 45 <solid android:color="@color/abb_accent_dark_blue_alpha"/>
43 <corners android:radius="1dp"/> 46 <corners android:radius="1dp"/>
44 </shape> 47 </shape>
45 48
46 </item> 49 </item>
47 50
48 <item gecko:state_recording="true"> 51 <item gecko:state_recording="true">
49 52
50 <shape android:shape="rectangle"> 53 <shape android:shape="rectangle">
51 <solid android:color="#FFFF0000"/> 54 <solid android:color="#FFFF0000"/>
(...skipping 20 matching lines...) Expand all
72 android:state_checked="true" 75 android:state_checked="true"
73 gecko:state_recording="false"> 76 gecko:state_recording="false">
74 77
75 <shape android:shape="rectangle"> 78 <shape android:shape="rectangle">
76 <solid android:color="@color/fennec_ui_orange"/> 79 <solid android:color="@color/fennec_ui_orange"/>
77 <corners android:radius="1dp"/> 80 <corners android:radius="1dp"/>
78 </shape> 81 </shape>
79 82
80 </item> 83 </item>
81 84
82 <!-- Adding inset border to normal state in order to follow ABB design guide --> 85 <!-- Adding inset border to normal state in order to follow ABB style guide -->
83 <!-- See https://issues.adblockplus.org/ticket/3769 --> 86 <!-- See https://issues.adblockplus.org/ticket/3769 -->
84 <item> 87 <item>
85 88
86 <inset android:insetBottom="2dp" android:insetLeft="2dp" android:insetRi ght="2dp" 89 <inset android:insetBottom="2dp" android:insetLeft="2dp" android:insetRi ght="2dp"
87 android:insetTop="2dp"> 90 android:insetTop="2dp">
88 91
89 <shape android:shape="rectangle"> 92 <shape android:shape="rectangle">
90 <solid android:color="@color/abb_border_grey" /> 93 <solid android:color="@color/abb_border_grey" />
91 <corners android:radius="1dp" /> 94 <corners android:radius="1dp" />
92 </shape> 95 </shape>
93 96
94 </inset> 97 </inset>
95 98
96 </item> 99 </item>
97 100
98 </selector> 101 </selector>
LEFTRIGHT

Powered by Google App Engine
This is Rietveld