Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: mobile/android/base/resources/values/themes.xml

Issue 29348083: Issue 3769 - UI colours gone bad (Closed)
Left Patch Set: Created July 21, 2016, 2:09 a.m.
Right Patch Set: Adjusting comments which indicates what has being changed by this issue in upstream code Created Oct. 25, 2016, 12:16 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « mobile/android/base/resources/values/styles.xml ('k') | mobile/android/base/tabs/TabStrip.java » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- This Source Code Form is subject to the terms of the Mozilla Public 2 <!-- This Source Code Form is subject to the terms of the Mozilla Public
3 - License, v. 2.0. If a copy of the MPL was not distributed with this 3 - License, v. 2.0. If a copy of the MPL was not distributed with this
4 - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> 4 - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
5 5
6 <resources> 6 <resources>
7
8 <!-- Using ABB color palette in some styles. See https://issues.adblockplus. org/ticket/3769 -->
9 7
10 <!-- 8 <!--
11 Base application theme. This could be overridden by GeckoBaseTheme 9 Base application theme. This could be overridden by GeckoBaseTheme
12 in other res/values-XXX/themes.xml. 10 in other res/values-XXX/themes.xml.
13 11
14 Bug 1215079: we inherit from android:* on GB but AppCompat in later vers ions. 12 Bug 1215079: we inherit from android:* on GB but AppCompat in later vers ions.
15 Inheriting only from the AppCompat style but not extending AppCompat cau ses the 13 Inheriting only from the AppCompat style but not extending AppCompat cau ses the
16 menu to be transparent and we can't correctly override the color on all devices 14 menu to be transparent and we can't correctly override the color on all devices
17 while also extending AppCompat disables the menu entirely due to a frame work bug. 15 while also extending AppCompat disables the menu entirely due to a frame work bug.
18 We're stuck until we always show the overflow menu (bug 1209967). 16 We're stuck until we always show the overflow menu (bug 1209967).
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 <item name="floatingHintEditTextStyle">@style/FloatingHintEditText</item > 112 <item name="floatingHintEditTextStyle">@style/FloatingHintEditText</item >
115 </style> 113 </style>
116 114
117 <!-- Make an activity appear like an overlay. --> 115 <!-- Make an activity appear like an overlay. -->
118 <style name="OverlayActivity" parent="Gecko"> 116 <style name="OverlayActivity" parent="Gecko">
119 <item name="android:windowBackground">@android:color/transparent</item> 117 <item name="android:windowBackground">@android:color/transparent</item>
120 <item name="android:windowNoTitle">true</item> 118 <item name="android:windowNoTitle">true</item>
121 <item name="android:windowIsTranslucent">true</item> 119 <item name="android:windowIsTranslucent">true</item>
122 <item name="android:backgroundDimEnabled">true</item> 120 <item name="android:backgroundDimEnabled">true</item>
123 121
122 <!-- Using ABB color palette. See https://issues.adblockplus.org/ticket/ 3769 -->
124 <!-- Set the app's title bar color in the recent app switcher. 123 <!-- Set the app's title bar color in the recent app switcher.
125 124
126 Note: We'd prefer not to show up in the recent app switcher (bug 11 37928). --> 125 Note: We'd prefer not to show up in the recent app switcher (bug 11 37928). -->
127 <item name="android:colorPrimary">@color/abb_background_light_grey</item > 126 <item name="android:colorPrimary">@color/abb_background_light_grey</item >
128 <!-- We display the overlay on top of other Activities so show their sta tus bar. --> 127 <!-- We display the overlay on top of other Activities so show their sta tus bar. -->
129 <item name="android:statusBarColor">@android:color/transparent</item> 128 <item name="android:statusBarColor">@android:color/transparent</item>
130 </style> 129 </style>
131 130
132 </resources> 131 </resources>
LEFTRIGHT

Powered by Google App Engine
This is Rietveld