Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: mobile/android/base/resources/values/themes.xml

Issue 29348083: Issue 3769 - UI colours gone bad (Closed)
Patch Set: Created July 21, 2016, 2:09 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mobile/android/base/resources/values/themes.xml
===================================================================
--- a/mobile/android/base/resources/values/themes.xml
+++ b/mobile/android/base/resources/values/themes.xml
@@ -1,15 +1,17 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- This Source Code Form is subject to the terms of the Mozilla Public
- License, v. 2.0. If a copy of the MPL was not distributed with this
- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<resources>
+ <!-- Using ABB color palette in some styles. See https://issues.adblockplus.org/ticket/3769 -->
+
<!--
Base application theme. This could be overridden by GeckoBaseTheme
in other res/values-XXX/themes.xml.
Bug 1215079: we inherit from android:* on GB but AppCompat in later versions.
Inheriting only from the AppCompat style but not extending AppCompat causes the
menu to be transparent and we can't correctly override the color on all devices
while also extending AppCompat disables the menu entirely due to a framework bug.
@@ -117,14 +119,14 @@
<item name="android:windowBackground">@android:color/transparent</item>
<item name="android:windowNoTitle">true</item>
<item name="android:windowIsTranslucent">true</item>
<item name="android:backgroundDimEnabled">true</item>
<!-- Set the app's title bar color in the recent app switcher.
Note: We'd prefer not to show up in the recent app switcher (bug 1137928). -->
- <item name="android:colorPrimary">@color/text_and_tabs_tray_grey</item>
+ <item name="android:colorPrimary">@color/abb_background_light_grey</item>
<!-- We display the overlay on top of other Activities so show their status bar. -->
<item name="android:statusBarColor">@android:color/transparent</item>
</style>
</resources>

Powered by Google App Engine
This is Rietveld