Unified Diff: mobile/android/base/resources/drawable/tab_thumbnail.xml
Issue 29348083:
Issue 3769 - UI colours gone bad (Closed)
Patch Set: Adjusting comments which indicates what has being changed by this issue in upstream code
Created Oct. 25, 2016, 12:16 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« mobile/android/base/resources/drawable/tab_item_close_button.xml ('k')
|
mobile/android/base/resources/layout-large-v11/browser_toolbar.xml » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: mobile/android/base/resources/drawable/tab_thumbnail.xml |
| =================================================================== |
| --- a/mobile/android/base/resources/drawable/tab_thumbnail.xml |
| +++ b/mobile/android/base/resources/drawable/tab_thumbnail.xml |
| @@ -4,50 +4,50 @@ |
| - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> |
| <selector xmlns:android="http://schemas.android.com/apk/res/android" |
| xmlns:gecko="http://schemas.android.com/apk/res-auto"> |
| <item android:state_focused="true"> |
| <shape android:shape="rectangle"> |
| - <!-- @color/fennec_ui_orange with alpha --> |
| - <solid android:color="#B3FF9500"/> |
| + <!-- Using ABB color palette. See https://issues.adblockplus.org/ticket/3769 --> |
| + <solid android:color="@color/abb_accent_dark_blue_alpha"/> |
| <corners android:radius="1dp"/> |
| </shape> |
| </item> |
| <item android:state_focused="true" |
| gecko:state_private="true"> |
| <shape android:shape="rectangle"> |
| - <!-- @color/private_browsing_purple with alpha --> |
| - <solid android:color="#B3CF68FF"/> |
| + <!-- Using ABB color palette. See https://issues.adblockplus.org/ticket/3769 --> |
| + <solid android:color="@color/abb_private_purple_alpha"/> |
| <corners android:radius="1dp"/> |
| </shape> |
| </item> |
| <item android:state_pressed="true" |
| gecko:state_private="true"> |
| <shape android:shape="rectangle"> |
| - <!-- @color/private_browsing_purple with alpha --> |
| - <solid android:color="#B3CF68FF"/> |
| + <!-- Using ABB color palette. See https://issues.adblockplus.org/ticket/3769 --> |
| + <solid android:color="@color/abb_private_purple_alpha"/> |
| <corners android:radius="1dp"/> |
| </shape> |
| </item> |
| <item android:state_pressed="true"> |
| <shape android:shape="rectangle"> |
| - <!-- @color/fennec_ui_orange with alpha --> |
| - <solid android:color="#B3FF9500"/> |
| + <!-- Using ABB color palette. See https://issues.adblockplus.org/ticket/3769 --> |
| + <solid android:color="@color/abb_accent_dark_blue_alpha"/> |
| <corners android:radius="1dp"/> |
| </shape> |
| </item> |
| <item gecko:state_recording="true"> |
| <shape android:shape="rectangle"> |
| @@ -77,11 +77,25 @@ |
| <shape android:shape="rectangle"> |
| <solid android:color="@color/fennec_ui_orange"/> |
| <corners android:radius="1dp"/> |
| </shape> |
| </item> |
| - <item android:drawable="@android:color/transparent"/> |
| + <!-- Adding inset border to normal state in order to follow ABB style guide --> |
| + <!-- See https://issues.adblockplus.org/ticket/3769 --> |
| + <item> |
| + |
| + <inset android:insetBottom="2dp" android:insetLeft="2dp" android:insetRight="2dp" |
| + android:insetTop="2dp"> |
| + |
| + <shape android:shape="rectangle"> |
| + <solid android:color="@color/abb_border_grey" /> |
| + <corners android:radius="1dp" /> |
| + </shape> |
| + |
| + </inset> |
| + |
| + </item> |
| </selector> |
« no previous file with comments
|
« mobile/android/base/resources/drawable/tab_item_close_button.xml ('k')
|
mobile/android/base/resources/layout-large-v11/browser_toolbar.xml » ('j')
|
no next file with comments »
