Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: mobile/android/base/resources/layout/browser_toolbar.xml

Issue 29348083: Issue 3769 - UI colours gone bad (Closed)
Patch Set: Adjusting comments which indicates what has being changed by this issue in upstream code Created Oct. 25, 2016, 12:16 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mobile/android/base/resources/layout/browser_toolbar.xml
===================================================================
--- a/mobile/android/base/resources/layout/browser_toolbar.xml
+++ b/mobile/android/base/resources/layout/browser_toolbar.xml
@@ -39,25 +39,25 @@
<org.mozilla.gecko.toolbar.ShapedButtonFrameLayout
android:id="@+id/menu"
style="@style/UrlBar.ImageButton"
android:layout_alignParentRight="true"
android:contentDescription="@string/menu"
android:background="@drawable/shaped_button"
android:visibility="gone">
+ <!-- Using ABB style. See https://issues.adblockplus.org/ticket/3769 -->
<org.mozilla.gecko.widget.themed.ThemedImageView
android:id="@+id/menu_icon"
- style="@style/UrlBar.ImageButton"
+ style="@style/Abb.BrowserToolbar.MenuIcon"
android:layout_height="@dimen/browser_toolbar_menu_icon_height"
android:layout_width="wrap_content"
android:scaleType="centerInside"
android:layout_gravity="center"
- android:src="@drawable/menu"
- android:tint="@color/tabs_tray_icon_grey"/>
+ android:src="@drawable/menu"/>
</org.mozilla.gecko.toolbar.ShapedButtonFrameLayout>
<org.mozilla.gecko.toolbar.PhoneTabsButton android:id="@+id/tabs"
style="@style/UrlBar.ImageButton"
android:layout_width="64dip"
android:layout_toLeftOf="@id/menu"
android:layout_alignWithParentIfMissing="true"

Powered by Google App Engine
This is Rietveld