mobile/android/base/toolbar/ToolbarEditLayout.java - Issue 29348083: Issue 3769 - UI colours gone bad

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: mobile/android/base/toolbar/ToolbarEditLayout.java

Issue 29348083: Issue 3769 - UI colours gone bad (Closed)

Patch Set: Adjusting comments which indicates what has being changed by this issue in upstream code Created Oct. 25, 2016, 12:16 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: mobile/android/base/toolbar/ToolbarEditLayout.java

===================================================================

--- a/mobile/android/base/toolbar/ToolbarEditLayout.java

+++ b/mobile/android/base/toolbar/ToolbarEditLayout.java

@@ -146,17 +146,18 @@ public class ToolbarEditLayout extends T

// When on tablet show a magnifying glass in editing mode

final int searchDrawableId = R.drawable.search_icon_active;

final Drawable searchDrawable;

if (!isActive) {

searchDrawable = DrawableUtil.tintDrawable(getContext(), searchDrawableId, R.color.placeholder_grey);

} else {

if (isPrivateMode()) {

- searchDrawable = DrawableUtil.tintDrawable(getContext(), searchDrawableId, R.color.tabs_tray_icon_grey);

+ // Modified in order to follow ABB style guide. See https://issues.adblockplus.org/ticket/3769

+ searchDrawable = DrawableUtil.tintDrawable(getContext(), searchDrawableId, R.color.private_active_text);

} else {

searchDrawable = getResources().getDrawable(searchDrawableId);

}

mSearchIcon.setImageDrawable(searchDrawable);

}