Unified Diff: README.md
Issue 29348393:
Issue 4259 - Change libadblockplus-android description in README (Closed)
Patch Set: Removed 'An'
Created Feb. 7, 2017, 5:29 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: README.md |
| diff --git a/README.md b/README.md |
| index 345956236ae16c0e3d6c24197822c9a89ab15784..fe3f2aa5bd59cbee427eeb58af39cde396251966 100644 |
| --- a/README.md |
| +++ b/README.md |
| @@ -1,17 +1,20 @@ |
| -Adblock Plus Library for Android |
| +Adblock Plus for Android |
|
Felix Dahlke
2017/02/09 14:31:44
That's a bit confusing since we have a product cal
anton
2017/02/10 10:24:37
Acknowledged.
|
| ======================== |
| An Android library project, tests and demo application for AdblockWebView widget. |
| ## Updating the dependencies |
| -Adblock Plus Library for Android has dependencies that aren't in this repository. |
| +Adblock Plus for Android has dependencies that aren't in this repository. |
| To update those, call: |
| ./ensure_dependencies.py |
| ## Library |
| +An Android library that provides an opportunity to use Adblock Plus core functionality |
|
Felix Dahlke
2017/02/09 14:31:44
Seems we could shorten this a bit:
"An Android li
anton
2017/02/10 10:24:37
Acknowledged.
|
| +in Java/Android. You can find adblock library in the 'libadblockplus-android' directory. |
| + |
| ### Building with Ant |
| #### Requirements |
| @@ -82,6 +85,9 @@ This will generate *.aar library artifact in the 'libadblockplus-android/build/o |
| ## Library tests |
| +Android tests for the Library. |
|
Felix Dahlke
2017/02/09 14:31:44
Same here:
"Android tests for the library. You ca
anton
2017/02/10 10:24:37
Acknowledged.
|
| +You can find adblock library tests in the 'libadblockplus-android-tests' directory. |
| + |
| ### Requirements |
| Make sure _Library_ requirements are present. |
| @@ -139,6 +145,7 @@ compiled, installed to emulator/device and launched automatically. |
| ## Settings |
| +An Android library for the settings UI. |
|
Felix Dahlke
2017/02/09 14:31:44
This one I'd stretch a bit :D Maybe:
"An Android
anton
2017/02/10 10:24:37
Acknowledged.
|
| You can find adblock fragments in the 'libadblockplus-android-settings' directory: |
| * GeneralSettingsFragment - main fragment |
| * WhitelistedDomainsSettingsFragment - whitelisted domains fragment |
| @@ -202,39 +209,9 @@ In the project root directory run: |
| This will generate *.aar in the 'libadblockplus-android-settings/build/outputs/aar' directory. |
| -## WebView Application |
| - |
| -You can find demo application for 'AdblockWebView' class in |
| -'libadblockplus-android-webviewapp' directory. |
| - |
| -### Building |
| - |
| -Make sure _Library_ requirements are present. |
| - |
| -#### Building with Ant |
| - |
| -In the 'libadblockplus-android-webviewapp' directory create the file _local.properties_ and set |
| -_sdk.dir_ to where you installed it, e.g.: |
| - |
| - sdk.dir = /some/where/sdk |
| - |
| -Then run: |
| - |
| - ant debug |
| - |
| -This will generate *.apk in the 'libadblockplus-android-webviewapp/bin/' directory. |
| - |
| -#### Building with Gradle |
| - |
| -In the project root directory run: |
| - |
| - ./gradlew assemble |
| - |
| -This will generate *.apk in the 'libadblockplus-android-webviewapp/build/outputs/apk/' directory. |
| - |
| - |
| ## WebView |
| +An Android library for WebView UI with Adblock Plus integrated. |
|
Felix Dahlke
2017/02/09 14:31:44
Maybe:
"An Android library that provides a WebVie
anton
2017/02/10 10:24:37
Acknowledged.
|
| You can find 'AdblockWebView' class in the 'libadblockplus-android-webview' directory. |
| `AdblockWebView` class provides built-in ad blocking |
| @@ -290,6 +267,7 @@ This will generate *.aar in the 'libadblockplus-android-webview/build/outputs/aa |
| ## WebView Application |
| +An Android application with AdblockWebView usage example. |
|
Felix Dahlke
2017/02/09 14:31:44
"An Android application that demonstrates how to u
anton
2017/02/10 10:24:37
Acknowledged.
|
| You can find demo application for 'AdblockWebView' class in the |
| 'libadblockplus-android-webviewapp' directory. |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
