Issue 4260 - Replace Apache Commons Lang classes

src/org/adblockplus/android/StringUtils.java

+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-2016 Eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package org.adblockplus.android;
+
+public class StringUtils
+{
+    public static boolean isNotEmpty(String value)
+    {
+        return value != null && value.length() > 0;
+    }
+
+    public static boolean isEmpty(String value)
+    {
+        return !isNotEmpty(value);
+    }
+
+    public static String join(Object[] array, String separator)

[anton, 2016/07/22 18:02:17]

tested according to
https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lan...
docs:

package org.adblockplus.libadblockplus.tests;

import org.adblockplus.android.StringUtils;
import org.junit.Test;
import junit.framework.*;

public class StringUtilsTest extends TestCase
{
	@Test
    public void testEmpty()
    {
		assertTrue(StringUtils.isEmpty(null));
		assertTrue(StringUtils.isEmpty(""));
		assertFalse(StringUtils.isEmpty(" "));
		assertFalse(StringUtils.isEmpty("bob"));
		assertFalse(StringUtils.isEmpty("  bob  "));
    }

	@Test
	public void testJoin()
	{
		assertNull(StringUtils.join(null, ""));
 		assertEquals("", StringUtils.join(new Object[] {}, ""));
 		assertEquals("", StringUtils.join(new Object[] {null}, ""));
 		assertEquals("a;b;c", StringUtils.join(new Object[] {"a", "b", "c"}, ";"));
 		assertEquals("abc", StringUtils.join(new Object[] {"a", "b", "c"}, null));
 		assertEquals(";;a", StringUtils.join(new Object[] {null, "", "a"}, ";"));
	}
}

+    {
+        if (array == null)
+        {
+            return null;
+        }
+
+        StringBuilder sb = new StringBuilder();
+        for (int i = 0; i < array.length; i++)
+        {
+            String eachValue = (String)array[i];

[anton, 2016/07/26 12:45:38]

this could be array[i].toString() but currently works for us

[René Jeschke, 2016/07/26 13:14:44]

Yeah. As we pass in 'Object[]' I really would love to see .toString() here.

[anton, 2016/07/26 13:22:04]

Acknowledged.

+            if (i > 0 && separator != null)
+            {
+                sb.append(separator);
+            }
+
+            if (eachValue != null)
+            { 
+                sb.append(eachValue);
+            }
+        }
+
+        return sb.toString();
+    }
+}