Issue 4353 - Fix syntax for modern Js Shell

lib/icon.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 87 matching lines @@
     loadImage("icons/abp-32-whitelisted.png"),
     loadImage("icons/abp-32-notification-" + notificationType + ".png"),
     loadImage("icons/abp-38.png"),
     loadImage("icons/abp-38-whitelisted.png"),
     loadImage("icons/abp-38-notification-" + notificationType + ".png"),
     loadImage("icons/abp-40.png"),
     loadImage("icons/abp-40-whitelisted.png"),
     loadImage("icons/abp-40-notification-" + notificationType + ".png")
   ]).then(images =>
   {
-    let images = {
+    let imageMap = {

[Sebastian Noack, 2016/08/24 11:30:04]

Why must this variable no longer be called "images"?

[kzar, 2016/08/24 12:24:43]

Js Shell got upset since images is also the name of a parameter in the
containing function.

       16: { base: [images[0], images[1]], overlay: images[2] },
       19: { base: [images[3], images[4]], overlay: images[5] },
       20: { base: [images[6], images[7]], overlay: images[8] },
       32: { base: [images[9], images[10]], overlay: images[11] },
       38: { base: [images[12], images[13]], overlay: images[14] },
       40: { base: [images[15], images[16]], overlay: images[17] }
     };
 
     let frames = {};
     let canvas = document.createElement("canvas");
     let context = canvas.getContext("2d");
 
     for (let whitelisted of [false, true])
     {
       for (let i = 0, opacity = 0; i <= 10; opacity = ++i / 10)
       {
         let imageData = {};
         let sizes = [16, 19, 20, 32, 38, 40];
         for (let size of sizes)
         {
           canvas.width = size;
           canvas.height = size;
           context.globalAlpha = 1;
-          context.drawImage(images[size]["base"][whitelisted | 0], 0, 0);
+          context.drawImage(imageMap[size]["base"][whitelisted | 0], 0, 0);
           context.globalAlpha = opacity;
-          context.drawImage(images[size]["overlay"], 0, 0);
+          context.drawImage(imageMap[size]["overlay"], 0, 0);
           imageData[size] = context.getImageData(0, 0, size, size);
         }
         frames["" + opacity + whitelisted] = imageData;
       }
     }
 
     return frames;
   });
 }
 
@@ skipping 82 matching lines @@
           clearInterval(interval);
           resolve();
           return;
         }
 
         animateIcon(type, frames);
       }, 10000);
     });
   });
 };