Issue 4353 - Remove deprecated __proto__ syntax

lib/coreUtils.js

+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-2016 Eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+function desc(properties)
+{
+  for (let property in properties)
+  {
+    let value = properties[property];
+    if (value == null || typeof value != "object")
+      properties[property] = {configurable: true, enumerable: true,
+                              writable: true, value: value};
+    else
+      value["configurable"] = value["enumerable"] = true;

[Wladimir Palant, 2016/09/02 08:17:13]

How about just calling Object.getOwnPropertyDescriptor(properties, property)?
Then you won't need to change the way getters and setters are defined in the
source code. Also, please create a new object for the return value rather than
messing with the parameter.

[kzar, 2016/09/02 11:53:21]

Wow, not sure why I didn't think of that! Done.

+  }
+  return properties;
+}
+exports.desc = desc;