Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: safari/ext/content.js

Issue 29353237: Issue 4361 - Pass all parameters to initEvent (Closed)
Patch Set: Created Sept. 15, 2016, 5:57 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | safari/include.youtube.js » ('j') | safari/include.youtube.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: safari/ext/content.js
diff --git a/safari/ext/content.js b/safari/ext/content.js
index 2c43b2dbef79aed4fb2a5458fcceea6fbb13a341..488abc7083ad92d39c4b04e2042a71aa4a2e16af 100644
--- a/safari/ext/content.js
+++ b/safari/ext/content.js
@@ -26,7 +26,7 @@
/* Intialization */
var beforeLoadEvent = document.createEvent("Event");
- beforeLoadEvent.initEvent("beforeload");
+ beforeLoadEvent.initEvent("beforeload", false, true);
// Decide if we should use the new content blocker API or not. (Note when the
// API is used Safari breaks the canLoad function, making it either throw an
@@ -153,7 +153,7 @@
setTimeout(function()
{
var evt = document.createEvent("Event");
- evt.initEvent(eventName);
+ evt.initEvent(eventName, false, true);
Sebastian Noack 2016/09/16 12:42:52 "load" and "error" event don't bubble. I think "be
Sebastian Noack 2016/09/16 12:48:52 Sorry, got it the wrong way around, the second arg
kzar 2016/09/16 13:00:43 Done.
event.target.dispatchEvent(evt);
});
}
« no previous file with comments | « no previous file | safari/include.youtube.js » ('j') | safari/include.youtube.js » ('J')

Powered by Google App Engine
This is Rietveld