libadblockplus-android/jni/JniCallbacks.h - Issue 29354787: Issue 4442 - Cache class and ctors references in JNI_Load/UnLoad

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: libadblockplus-android/jni/JniCallbacks.h

Issue 29354787: Issue 4442 - Cache class and ctors references in JNI_Load/UnLoad (Closed)

Left Patch Set: Created Sept. 23, 2016, 12:55 p.m.

Right Patch Set: reverted to NewTuple Created Nov. 21, 2016, 8:25 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-2016 Eyeo GmbH	3 * Copyright (C) 2006-2016 Eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 80 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
91 void Callback(const AdblockPlus::NotificationPtr&);	91 void Callback(const AdblockPlus::NotificationPtr&);

92 };	92 };

93	93

94 class JniWebRequest : public JniCallbackBase, public AdblockPlus::WebRequest	94 class JniWebRequest : public JniCallbackBase, public AdblockPlus::WebRequest

95 {	95 {

96 public:	96 public:

97 JniWebRequest(JNIEnv* env, jobject callbackObject);	97 JniWebRequest(JNIEnv* env, jobject callbackObject);

98 AdblockPlus::ServerResponse GET(const std::string& url, const AdblockPlus::Hea derList& requestHeaders) const;	98 AdblockPlus::ServerResponse GET(const std::string& url, const AdblockPlus::Hea derList& requestHeaders) const;

99	99

100 private:	100 private:

101 jobject NewHeaderEntry(JNIEnv* env, const std::string& a, const std::string& b ) const;	101 jobject NewTuple(JNIEnv* env, const std::string& a, const std::string& b) cons t;

102 };	102 };

103	103

104 #endif /* JNICALLBACKS_H */	104 #endif /* JNICALLBACKS_H */

LEFT	RIGHT