libadblockplus-android/jni/JniFilterChangeCallback.cpp - Issue 29354787: Issue 4442 - Cache class and ctors references in JNI_Load/UnLoad

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android/jni/JniFilterChangeCallback.cpp

Issue 29354787: Issue 4442 - Cache class and ctors references in JNI_Load/UnLoad (Closed)

Patch Set: Created Sept. 23, 2016, 12:55 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: libadblockplus-android/jni/JniFilterChangeCallback.cpp

diff --git a/libadblockplus-android/jni/JniFilterChangeCallback.cpp b/libadblockplus-android/jni/JniFilterChangeCallback.cpp

index 406f4fe1bb59531a634bc27e1b706cd20cab8389..28959b34a2b802ef75a0ea810d9c8aaacb9e6218 100644

--- a/libadblockplus-android/jni/JniFilterChangeCallback.cpp

+++ b/libadblockplus-android/jni/JniFilterChangeCallback.cpp

@@ -33,8 +33,7 @@ static void JNICALL JniDtor(JNIEnv* env, jclass clazz, jlong ptr)

JniFilterChangeCallback::JniFilterChangeCallback(JNIEnv* env,

jobject callbackObject)

- : JniCallbackBase(env, callbackObject), jsValueClass(

- new JniGlobalReference<jclass>(env, env->FindClass(PKG("JsValue"))))

+ : JniCallbackBase(env, callbackObject)

{

}

@@ -51,8 +50,7 @@ void JniFilterChangeCallback::Callback(const std::string& arg,

if (method)

{

JniLocalReference<jstring> jArg(*env, env->NewStringUTF(arg.c_str()));

- JniLocalReference<jobject> jJsValue(*env,

- NewJniJsValue(*env, jsValue, jsValueClass->Get()));

+ JniLocalReference<jobject> jJsValue(*env, NewJniJsValue(*env, jsValue, GetJsValueClass()));

env->CallVoidMethod(GetCallbackObject(), method, *jArg, *jJsValue);

}