Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: test/filterNotifier.js

Issue 29354864: Issue 4223 - Migrate some more of adblockplustests (Closed)
Left Patch Set: Addressed feedback Created Oct. 3, 2016, 1:44 p.m.
Right Patch Set: Addressed final nit Created Oct. 4, 2016, 12:16 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « test/filterListener.js ('k') | test/filterStorage.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 "use strict"; 18 "use strict";
19 19
20 let {createSandbox} = require("common"); 20 let {createSandbox} = require("./_common");
21 21
22 let FilterNotifier = null; 22 let FilterNotifier = null;
23 23
24 exports.setUp = function(callback) 24 exports.setUp = function(callback)
25 { 25 {
26 let sandboxedRequire = createSandbox(); 26 let sandboxedRequire = createSandbox();
27 ( 27 (
28 {FilterNotifier} = sandboxedRequire("filterNotifier") 28 {FilterNotifier} = sandboxedRequire("../lib/filterNotifier")
29 ); 29 );
30 30
31 callback(); 31 callback();
32 }; 32 };
33 33
34 let triggeredListeners = []; 34 let triggeredListeners = [];
35 let listeners = [ 35 let listeners = [
36 (action, item) => triggeredListeners.push(["listener1", action, item]), 36 (action, item) => triggeredListeners.push(["listener1", action, item]),
37 (action, item) => triggeredListeners.push(["listener2", action, item]), 37 (action, item) => triggeredListeners.push(["listener2", action, item]),
38 (action, item) => triggeredListeners.push(["listener3", action, item]) 38 (action, item) => triggeredListeners.push(["listener3", action, item])
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 }; 98 };
99 let listener2 = listeners[1]; 99 let listener2 = listeners[1];
100 FilterNotifier.addListener(listener1); 100 FilterNotifier.addListener(listener1);
101 FilterNotifier.addListener(listener2); 101 FilterNotifier.addListener(listener2);
102 102
103 compareListeners(test, "Initial call", [listener1, listener2]); 103 compareListeners(test, "Initial call", [listener1, listener2]);
104 compareListeners(test, "Subsequent calls", [listener2]); 104 compareListeners(test, "Subsequent calls", [listener2]);
105 105
106 test.done(); 106 test.done();
107 }; 107 };
LEFTRIGHT

Powered by Google App Engine
This is Rietveld