Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: test_runner.js

Issue 29354864: Issue 4223 - Migrate some more of adblockplustests (Closed)
Left Patch Set: Addressed feedback Created Oct. 4, 2016, 12:04 p.m.
Right Patch Set: Addressed final nit Created Oct. 4, 2016, 12:16 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « test/subscriptionClasses.js ('k') | test_wrapper.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 19 matching lines...) Expand all
30 let stat = fs.statSync(testPath); 30 let stat = fs.statSync(testPath);
31 if (stat.isDirectory()) 31 if (stat.isDirectory())
32 { 32 {
33 if (recurse) 33 if (recurse)
34 { 34 {
35 addTestPaths(fs.readdirSync(testPath).map( 35 addTestPaths(fs.readdirSync(testPath).map(
36 file => path.join(testPath, file))); 36 file => path.join(testPath, file)));
37 } 37 }
38 } 38 }
39 else if (path.extname(testPath) == ".js" && 39 else if (path.extname(testPath) == ".js" &&
40 path.basename(testPath)[0] != "_") 40 !path.basename(testPath).startsWith("_"))
Wladimir Palant 2016/10/04 12:15:05 Nit: !path.basename(testPath).startsWith("_")
kzar 2016/10/04 12:17:26 Done.
41 { 41 {
42 files.push(testPath); 42 files.push(testPath);
43 } 43 }
44 } 44 }
45 } 45 }
46 if (process.argv.length > 2) 46 if (process.argv.length > 2)
47 addTestPaths(process.argv.slice(2), true); 47 addTestPaths(process.argv.slice(2), true);
48 else 48 else
49 addTestPaths([path.join(__dirname, "test")], true); 49 addTestPaths([path.join(__dirname, "test")], true);
50 50
51 nodeunit.reporters.default.run(files); 51 nodeunit.reporters.default.run(files);
LEFTRIGHT

Powered by Google App Engine
This is Rietveld