Noissue - fix according to coding style

lib/main.js

 /*
  * This Source Code is subject to the terms of the Mozilla Public License
  * version 2.0 (the "License"). You can obtain a copy of the License at
  * http://mozilla.org/MPL/2.0/.
  */
 
+'use strict';
+
 /**
  * @module main
  */
 
-Cu.import("resource://gre/modules/XPCOMUtils.jsm");
-Cu.import("resource://gre/modules/Services.jsm");
-Cu.import("resource://gre/modules/Promise.jsm");
+const {XPCOMUtils} = Cu.import("resource://gre/modules/XPCOMUtils.jsm", {});

[Wladimir Palant, 2016/09/29 10:36:10]

Why did you remove Services.jsm? It is being used here.

Note that the code still works because the global Services variable from
bootstrap.js is leaking through - that's a bug.

 
 require("commandLine");
 let {run} = require("crawler");
 
 let baseURL = null;
 
 /**
  * Waits for the application to initialize.
  * @type {Promise}
  */
 let applicationReady = (function()
 {
-  let deferred = Promise.defer();
+  let resolveWindowsRestored;
 
   let observer = {
     observe: function(subject, topic, data)
     {
       Services.obs.removeObserver(this, "sessionstore-windows-restored");
-      deferred.resolve();
+      resolveWindowsRestored();
     },
     QueryInterface: XPCOMUtils.generateQI([Ci.nsIObserver, Ci.nsISupportsWeakReference])
   };
-
+  let windowsRestored = new Promise((resolve) => resolveWindowsRestored = resolve);
   Services.obs.addObserver(observer, "sessionstore-windows-restored", true);
   onShutdown.add(() => Services.obs.removeObserver(observer, "sessionstore-windows-restored"));
 
-  return deferred.promise;
+  return windowsRestored;

[Wladimir Palant, 2016/09/29 10:36:10]

This is not how the code should be structured - you should rather move
everything into the callback:

  return new Promise((resolve, reject) =>
  {
    let observer = ...;
    addObserver(...);
    onShutdown.add(...);
  });

Also, please don't leave out the reject parameter even though you aren't using
it.

[sergei, 2016/09/29 12:46:16]

Done in https://codereview.adblockplus.org/29355271/

 })();
 
 /**
  * Startup function, called from command line handler.
  *
  * @param {int} port  Port to communicate with
  */
 function startup(port)
 {
   baseURL = "http://localhost:" + port + "/";
@@ skipping 32 matching lines @@
 
 /**
  * Called if requesting parameters failed.
  *
  * @param {Event} event
  */
 function onParametersFailed(event)
 {
   Cu.reportError("Failed loading parameters");
 }