Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: lib/main.js

Issue 29355271: Noissue - Don't import JavaScript modules into the global scope (includes removing unused module). (Closed)
Patch Set: Created Sept. 29, 2016, 12:05 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« lib/crawler.js ('K') | « lib/crawler.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This Source Code is subject to the terms of the Mozilla Public License 2 * This Source Code is subject to the terms of the Mozilla Public License
3 * version 2.0 (the "License"). You can obtain a copy of the License at 3 * version 2.0 (the "License"). You can obtain a copy of the License at
4 * http://mozilla.org/MPL/2.0/. 4 * http://mozilla.org/MPL/2.0/.
5 */ 5 */
6 6
7 "use strict"; 7 "use strict";
8 8
9 /** 9 /**
10 * @module main 10 * @module main
11 */ 11 */
12 12
13 Cu.import("resource://gre/modules/XPCOMUtils.jsm"); 13 const {Services} = Cu.import("resource://gre/modules/Services.jsm", {});
14 Cu.import("resource://gre/modules/Services.jsm"); 14 const {XPCOMUtils} = Cu.import("resource://gre/modules/XPCOMUtils.jsm", {});
15 Cu.import("resource://gre/modules/Promise.jsm"); 15 const {Promise} = Cu.import("resource://gre/modules/Promise.jsm", {});
16 16
17 require("commandLine"); 17 require("commandLine");
18 let {run} = require("crawler"); 18 let {run} = require("crawler");
19 19
20 let baseURL = null; 20 let baseURL = null;
21 21
22 /** 22 /**
23 * Waits for the application to initialize. 23 * Waits for the application to initialize.
24 * @type {Promise} 24 * @type {Promise}
25 */ 25 */
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 85
86 /** 86 /**
87 * Called if requesting parameters failed. 87 * Called if requesting parameters failed.
88 * 88 *
89 * @param {Event} event 89 * @param {Event} event
90 */ 90 */
91 function onParametersFailed(event) 91 function onParametersFailed(event)
92 { 92 {
93 Cu.reportError("Failed loading parameters"); 93 Cu.reportError("Failed loading parameters");
94 } 94 }
OLDNEW
« lib/crawler.js ('K') | « lib/crawler.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld