Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: build.py

Issue 29359878: Issue 4566 - Remove crashreporter check from adblockbrowser-build/build.py (Closed)
Patch Set: Created Oct. 25, 2016, 2:23 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build.py
===================================================================
--- a/build.py
+++ b/build.py
@@ -28,22 +28,16 @@ Usage: $name build
def check_mozconfig(path, distribution_mode, build_mode):
if not os.path.exists(path):
raise Exception("'%s' doesn't exist, please create it." % path)
with open(path) as file:
contents = file.read()
- # This check can be removed once https://issues.adblockplus.org/ticket/2490 is
- # done.
- if "--disable-crashreporter" not in contents:
- raise Exception(
- "'%s' doesn't seem to set --disable-crashreporter, please do." % path)
-
if "export MOZILLA_OFFICIAL=1" not in contents:
raise Exception(
"'%s' doesn't seem to export MOZILLA_OFFICIAL=1, please do." % path)
updater_disabled = "--disable-updater" in contents
if updater_disabled and distribution_mode == "standalone":
raise Exception("'%s' seems to set --disable-updater, please don't." % path)
elif not updater_disabled and distribution_mode == "store":
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld