libadblockplus-android/src/org/adblockplus/libadblockplus/android/Subscription.java - Issue 29361445: Issue 4399 - Add WebView inheritor with ad blocking

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android/src/org/adblockplus/libadblockplus/android/Subscription.java

Issue 29361445: Issue 4399 - Add WebView inheritor with ad blocking (Closed)

Patch Set: fixes according to Diego's suggestions Created Nov. 9, 2016, 12:27 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « libadblockplus-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequest.java ('k') | libadblockplus-android/src/org/adblockplus/libadblockplus/android/Utils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: libadblockplus-android/src/org/adblockplus/libadblockplus/android/Subscription.java

diff --git a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/ThrowingWebRequest.java b/libadblockplus-android/src/org/adblockplus/libadblockplus/android/Subscription.java

similarity index 71%

copy from libadblockplus-android-tests/src/org/adblockplus/libadblockplus/ThrowingWebRequest.java

copy to libadblockplus-android/src/org/adblockplus/libadblockplus/android/Subscription.java

index dcafa5bdab4e5ab0339369bb78f36a8f41727e5e..ecad4287f7d4d04b4c2b7af2b2398bf6945e8713 100644

--- a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/ThrowingWebRequest.java

+++ b/libadblockplus-android/src/org/adblockplus/libadblockplus/android/Subscription.java

@@ -15,15 +15,16 @@

* along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.

-package org.adblockplus.libadblockplus;

+package org.adblockplus.libadblockplus.android;

-import java.util.List;

+import java.io.Serializable;

-public class ThrowingWebRequest extends WebRequest

+public class Subscription implements Serializable

{

- @Override

- public ServerResponse httpGET(String url, List<HeaderEntry> headers)

- {

- throw new RuntimeException("Unexpected GET: " + url);

- }

+ public String title;

+ public String specialization;

+ public String url;

+ public String homepage;

+ public String[] prefixes;

+ public String author;

}